Modify cloudwatch sink to use FixedThreadPool#5770
Merged
Conversation
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
sb2k16
reviewed
Jun 11, 2025
| @Max(15) | ||
| private int maxRetries = DEFAULT_RETRY_COUNT; | ||
|
|
||
| @JsonProperty(value = "num_threads", defaultValue = "10") |
Member
There was a problem hiding this comment.
should we call this workers like we do in other cases.
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
sb2k16
approved these changes
Jun 11, 2025
san81
approved these changes
Jun 11, 2025
jeffreyAaron
pushed a commit
to jeffreyAaron/data-prepper
that referenced
this pull request
Jun 13, 2025
* Modify cloudwatch sink to use FixedThreadPool Signed-off-by: Krishna Kondaka <krishkdk@amazon.com> * Addressed comments Signed-off-by: Krishna Kondaka <krishkdk@amazon.com> --------- Signed-off-by: Krishna Kondaka <krishkdk@amazon.com> Signed-off-by: Jeffrey Aaron Jeyasingh <jeffreyaaron06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify cloudwatch sink to use FixedThreadPool. The existing
newCachedThreadPool()creates huge amount of threads (leading to out of memory error in some cases) when there is large amount of events created.Modified the code to use
newFixedThreadPool().Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.