Iterate on support for add_entries and delete_entries processors#5773
Merged
graytaylor0 merged 5 commits intoJun 13, 2025
Conversation
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
san81
previously approved these changes
Jun 11, 2025
san81
left a comment
san81
left a comment
Collaborator
There was a problem hiding this comment.
Nice enhancement. We should see if this can be more generalizable to be able too apply to other processors as well.
…add options for delete_from_element_when and add_to_element_when Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
changed the title
kkondaka
approved these changes
Jun 13, 2025
san81
approved these changes
Jun 13, 2025
san81
left a comment
san81
left a comment
Collaborator
There was a problem hiding this comment.
Nice separation of logic to make it clear and maintainable
jeffreyAaron
pushed a commit
to jeffreyAaron/data-prepper
that referenced
this pull request
Jun 13, 2025
…nsearch-project#5773) Signed-off-by: George Chen <qchea@amazon.com> Signed-off-by: Taylor Gray <tylgry@amazon.com> Co-authored-by: George Chen <qchea@amazon.com> Signed-off-by: Jeffrey Aaron Jeyasingh <jeffreyaaron06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes this unfinished PR (#5620) by rebasing and fixing merge conflicts
Also manually tested
Issues Resolved
Resolves #2853
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.