PoC for jib#5870
Conversation
Signed-off-by: Robert Macaulay <robert.macaulay@gmail.com>
|
looks like the failed test was where it checked out main, not my branch. There is no dockerPrepare in the project anymore, so I'm not sure what that's doing. |
|
Thank you @taer for experimenting with this. I'm not very familiar with jib, so I'll try to look into that a little more. One think to take note of is that we do use Docker to build the end-to-end tests. Data Prepper has a small set of end-to-test tests to verify certain behaviors. To run the tests, they do two things:
See this project: We would need to update at least the Docker test to use the jib build. Also, could we move the jib build into |
There was a problem hiding this comment.
Can we point to jib to use the existing keystore from here?
| } | ||
|
|
||
|
|
||
| jib { |
There was a problem hiding this comment.
It would be nice to use jib only from the :release:docker project. Is that possible?
| */ | ||
|
|
||
| plugins { | ||
| id 'com.palantir.docker' version '0.35.0' |
There was a problem hiding this comment.
This would also help since this plugin is now deprecated. So using job would resolve #5313 as well.
|
Just following up. I've been swamped. I managed to stand it up on amd64s, and now have been pulled in 4 different directions. I'll see if I can revisit this soon |
|
@taer , Data Prepper now supports Docker images which is what I believe this was aiming to support. I'm going to close this. If you believe it is still needed, please open an issue or a new PR. |
2 participants
Description
[Describe what this change achieves]
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.