Support isolation.level config for Kafka consumer#5894
Merged
dlvenable merged 1 commit intoAug 1, 2025
Conversation
lhooss
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
requested changes
Jul 29, 2025
| @JsonProperty("fetch_min_bytes") | ||
| private ByteCount fetchMinBytes = DEFAULT_FETCH_MIN_BYTES; | ||
|
|
||
| @JsonProperty("isolation_level") |
Member
There was a problem hiding this comment.
Please add this to CommonTopicConfig instead of here and SourceTopicConfig. It will make it common between the two.
Member
There was a problem hiding this comment.
Actually, the buffer would need to support transactions. Let's just remove it from BufferTopicConfig and make this a source property only.
I understand from #5896 that you are using Kafka as a source.
lhooss
force-pushed
the
feat/support-isolation-level
branch
from
0282215 to
3002461
Compare
Contributor
Author
@dlvenable Thank you for your feedback and for reviewing the PR! |
lhooss
force-pushed
the
feat/support-isolation-level
branch
3 times, most recently
from
72566e5 to
2f1060a
Compare
Signed-off-by: Mohamed Houssam LAHRACH <lahrach.houssam@gmail.com>
lhooss
force-pushed
the
feat/support-isolation-level
branch
from
2f1060a to
39c2ee7
Compare
graytaylor0
approved these changes
Aug 1, 2025
san81
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for the
isolation.levelKafka consumer configuration in Data Prepper.The following changes were made:
Introduced a new method
getIsolationLevel()in theTopicConsumerConfiginterface.Implemented the new property
isolation_levelwith a default value of"read_uncommitted"in both:SourceTopicConfig(Kafka source plugin)BufferTopicConfig(Kafka buffer plugin)Ensured backward compatibility by setting sensible defaults and integrating with existing configuration parsing logic.
This allows users to configure Data Prepper to read only committed messages by setting
isolation_level: read_committedin their pipeline YAML file.This is especially useful when working with transactional Kafka producers and ensures message consistency in distributed systems.
Issues Resolved
Resolves #5896
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.