S3 scheduled scan should consider start time on subsequent scans#5920
Merged
Conversation
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
san81
approved these changes
Jul 29, 2025
shenkw1
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, it was possible for subsequent s3 scans to ignore the start_time or range during scheduled scan so that old objects could be processed. This change just checks start time in all scan cases to ensure no older objects are discovered on subsequent scans
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.