Move submission of exectuor service to end of opensearch sink initialization#5922
Merged
Merged
Conversation
san81
previously approved these changes
Jul 30, 2025
Davidding4718
approved these changes
Jul 30, 2025
dlvenable
previously requested changes
Jul 31, 2025
| pluginMetrics, connectionConfiguration, clientFunction); | ||
|
|
||
| if (queryExecutorService != null) { | ||
| if (queryExecutorService != null && existingDocumentQueryManager == null) { |
Member
There was a problem hiding this comment.
A bug fix like this should have a unit test that reproduces the issue along with the fix.
Member
Author
There was a problem hiding this comment.
Added unit test coverage and confirmed without the change the test will fail
364dee6 to
e098ebe
Compare
…nsearch sink Signed-off-by: Taylor Gray <tylgry@amazon.com>
e098ebe to
f29c3e2
Compare
sb2k16
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If using the query_lookup and there is an exception initializing the sink, retries will result in a RejectedExecutionException.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.