Adds a null check when reading an S3EventNotification for records. So…#5933
Merged
dlvenable merged 1 commit intoJul 31, 2025
Merged
Conversation
…me recent change resulted in ObjectMapper::treeToValue return null for an empty string. Signed-off-by: David Venable <dlv@amazon.com>
graytaylor0
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some recent change has
SqsWorkerTestfailing. resulted inObjectMapper::treeToValuereturn null for an empty string.Upon debugging I see that
objectMapper.treeToValue(eventNode, S3EventNotification.class);is being called with an empty string and returningnull.The solution is to add a null check.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.