fix TranslateProcessorConfig to load target.type property correctly #5969
Merged
graytaylor0 merged 1 commit intoAug 7, 2025
Merged
Conversation
Contributor
|
DCO check is failing, we need to add sign off for every commit like this: |
…x#5961) **What?** This commit update TranslateProcessorConfig to load the target.type property from pipeline config with Jackson's support. The cause is that converter parameter is not updated while Jackson parsing the target.type properly. The fix removes the unncessary private field converter and instead return targetType. It also make secondar contstructor protected for unit test only. **Why?** Make target.type property in translate processor to take effect. Signed-off-by: Wenjie Yao <wjyao@amazon.com>
12bdbbd to
0798fdf
Compare
graytaylor0
approved these changes
Aug 6, 2025
san81
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…961)
Description
What?
This commit update TranslateProcessorConfig to load the target.type property from pipeline config with Jackson's support. The cause is that converter parameter is not updated while Jackson parsing the target.type properly. The fix removes the unncessary private field converter and instead return targetType.
It also make secondar contstructor protected for unit test only.
Why?
Make target.type property in translate processor to take effect.
Issues Resolved
Resolves #[5961]
Check List
Setup
Input:
Output
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.