Add logging for when secret is unable to be retrieved#6014
Merged
Conversation
graytaylor0
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
force-pushed
the
AddLogging
branch
from
f12df49 to
4131a0f
Compare
san81
reviewed
Aug 26, 2025
| try { | ||
| getSecretValueResponse = secretsManagerClient.getSecretValue(getSecretValueRequest); | ||
| } catch (Exception e) { | ||
| LOG.error("Unable to retrieve secret {}", getSecretValueRequest.secretId(), e); |
Collaborator
There was a problem hiding this comment.
Should we shutdown the pipeline in this case?
In the case of SAAS based pipelines, either won't even come up in this case or even if it comes up, it will be retrying forever which will be no use anyway!
Member
There was a problem hiding this comment.
Let's split this exception in two so that we can avoid walls of exceptions for expected errors.
catch(AwsException ex) {
LOG.error("Unable to retrieve secret {}", getSecretValueRequest.secretId(), e.getMessage());
} catch(Exception ex) {
LOG.error("Unable to retrieve secret {} due to unexpected error.", getSecretValueRequest.secretId(), e);
}
dlvenable
requested changes
Aug 26, 2025
| try { | ||
| getSecretValueResponse = secretsManagerClient.getSecretValue(getSecretValueRequest); | ||
| } catch (Exception e) { | ||
| LOG.error("Unable to retrieve secret {}", getSecretValueRequest.secretId(), e); |
Member
There was a problem hiding this comment.
Let's split this exception in two so that we can avoid walls of exceptions for expected errors.
catch(AwsException ex) {
LOG.error("Unable to retrieve secret {}", getSecretValueRequest.secretId(), e.getMessage());
} catch(Exception ex) {
LOG.error("Unable to retrieve secret {} due to unexpected error.", getSecretValueRequest.secretId(), e);
}
Member
|
Also, the tests are failing. Maybe something with the PR? |
Member
Author
I don't think it's failing due to PR |
graytaylor0
force-pushed
the
AddLogging
branch
from
4131a0f to
53634d1
Compare
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
AddLogging
branch
from
53634d1 to
90d79a0
Compare
dlvenable
approved these changes
Aug 26, 2025
Member
|
The failing tests are not caused by this and should be fixed in #6017. |
JonahCalvo
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds error log that is swallowed for when secret can't be retrieved.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.