S3 sink without path_prefix provided should write to bucket root#6101
Merged
Conversation
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
san81
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
sb2k16 and
srikanthjg
as code owners
graytaylor0
reviewed
Sep 24, 2025
| @@ -35,7 +35,8 @@ public KeyGenerator(final S3SinkConfig s3SinkConfig, | |||
| */ | |||
| public String generateKeyForEvent(final Event event) { | |||
| final String pathPrefix = s3BucketSelector != null ? s3BucketSelector.getPathPrefix() : ObjectKey.buildingPathPrefix(s3SinkConfig, event, expressionEvaluator); | |||
Member
There was a problem hiding this comment.
I think the NPE comes from the call to buildingPathPrefix here, so this change doesn't prevent it
Collaborator
Author
There was a problem hiding this comment.
ObjectKey.buildingPathPrefix method fix is also included in this PR.
graytaylor0
approved these changes
Sep 24, 2025
dlvenable
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
object_keyandpath_prefixconfiguration options under S3 sink are optional. If not provided, S3 sink should write to the root of the bucket, but in the current state, it is failing. This code change fixes it.Issues Resolved
Resolves #6090
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.