Skip to content

[Backport 2.12] Use standard TLS when downloading the database from an HTTP URL. #6167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlvenable merged 1 commit into from
Oct 14, 2025
Merged

[Backport 2.12] Use standard TLS when downloading the database from an HTTP URL. #6167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions ...in/java/org/opensearch/dataprepper/plugins/geoip/extension/databasedownload/DBSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,50 +5,7 @@

package org.opensearch.dataprepper.plugins.geoip.extension.databasedownload;

import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.HttpsURLConnection;
import javax.net.ssl.SSLContext;
import javax.net.ssl.SSLSession;
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509TrustManager;
import java.security.KeyManagementException;
import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;
import java.security.cert.CertificateException;
import java.security.cert.X509Certificate;

public interface DBSource {
String MAXMIND_DATABASE_EXTENSION = ".mmdb";
void initiateDownload() throws Exception;

/**
* initiateSSL
* @throws NoSuchAlgorithmException NoSuchAlgorithmException
* @throws KeyManagementException KeyManagementException
*/
default void initiateSSL() throws NoSuchAlgorithmException, KeyManagementException {
final TrustManager[] trustAllCerts = new TrustManager[]{
new X509TrustManager() {
public X509Certificate[] getAcceptedIssuers() {
return null;
}
public void checkServerTrusted(X509Certificate[] certs, String authType) throws CertificateException {
return;
}
public void checkClientTrusted(X509Certificate[] certs, String authType) throws CertificateException {
return;
}
}
};

final SSLContext sc = SSLContext.getInstance("TLS");
sc.init(null, trustAllCerts, new SecureRandom());
HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());
final HostnameVerifier hostnameVerifier = new HostnameVerifier() {
public boolean verify(String urlHostName, SSLSession session) {
return true;
}
};
HttpsURLConnection.setDefaultHostnameVerifier(hostnameVerifier);
}
}
1 change: 0 additions & 1 deletion ...pensearch/dataprepper/plugins/geoip/extension/databasedownload/HttpDBDownloadService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public void initiateDownload() {
for (final String key: databasePaths) {
geoIPFileManager.createDirectoryIfNotExist(tarDir);
try {
initiateSSL();
buildRequestAndDownloadFile(maxMindDatabaseConfig.getDatabasePaths().get(key), downloadTarFilepath);
final File tarFile = decompressAndgetTarFile(tarDir, downloadTarFilepath);
unTarFile(tarFile, new File(destinationDirectory), key);
Expand Down
Loading