Add negative tests to sqs and cloudwatch logs sink#6189
Merged
Conversation
Signed-off-by: Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
requested changes
Oct 21, 2025
| Collection<Record<Event>> records = getRecordList(NUM_RECORDS); | ||
| sink.doOutput(records); | ||
|
|
||
| assertThrows( org.awaitility.core.ConditionTimeoutException.class, () -> await().atMost(Duration.ofSeconds(30)) |
Member
There was a problem hiding this comment.
As I understand this, Awaitility will keep looking for this assertion for 30 seconds. And in the end, you don't want it to succeed.
In this case, it might be clearer to just use a sleep. That is all you are trying to do - determine the end state after 30 seconds.
Also, can we reduce this time? Thirty seconds is going to be a long time in our tests.
| int numRecords = 2; | ||
| Collection<Record<Event>> records = getRecordList(numRecords, false); | ||
| sink.doOutput(records); | ||
| assertThrows( org.awaitility.core.ConditionTimeoutException.class, () -> await().atMost(Duration.ofSeconds(60)) |
Member
There was a problem hiding this comment.
I have similar comments as above.
Also, one minute is a long time to delay the tests!
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
approved these changes
Oct 22, 2025
graytaylor0
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add negative tests to sqs and cloudwatch logs sink to verify that when correct credentials were not passed, Data Prepper cannot communicate with the sqs/cloudwatch service.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.