Fixing the crawler framework to handle ddb outage scenario#6207
Merged
san81 merged 3 commits intoOct 30, 2025
Conversation
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
san81
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
sb2k16 and
srikanthjg
as code owners
graytaylor0
previously approved these changes
Oct 30, 2025
dlvenable
requested changes
Oct 30, 2025
| // it should give up leader partition and require whenever ddb store reachable again | ||
| // Not giving up will make this to continue hold on to an ownership expired record which will create inconsistent state issues | ||
| // if you are not the owner in ddb table, then you are not supposed to hold the ownership | ||
| leaderPartition = null; |
Member
There was a problem hiding this comment.
Please include a unit test for this scenario and the expected outcome.
Collaborator
Author
There was a problem hiding this comment.
Added a unit test to validate reacquiring scenario.
…ition state after ddb calls succeed Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
dlvenable
reviewed
Oct 30, 2025
| }); | ||
| } | ||
|
|
||
| @Test |
Member
There was a problem hiding this comment.
You can move your comment to the test name to make it easier to read.
@Test("Ensure that if DynamoDB becomes unreachable, the leader gives up the partition and retries acquisition")
Collaborator
Author
There was a problem hiding this comment.
Added @DidsplayName annotation with the description
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
graytaylor0
approved these changes
Oct 30, 2025
dlvenable
approved these changes
Oct 30, 2025
vecheka
pushed a commit
to vecheka/data-prepper-m365-specific-metric-names
that referenced
this pull request
Oct 31, 2025
…h-project#6207) * Fixing the crawler framework to handle ddb outage scenario Signed-off-by: Vecheka Chhourn <vecheka@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Crawler framework relay on Source Coordinator framework which uses DDB as its store for state management. In an event when DDB store becomes unreachable, the expectation is that, pipeline should fully recover back to normal state as soon as ddb is accessible. In its current state, leader scheduler is holding onto an expired ownership record, which is preventing it from fully recovering after DDB comes back to normal state. The fix is to give up the partition when ddb store is unavailable so that it can freshly require when the store comes back online and reachable.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.