Fix acknowledgement timeout handling in DefaultAcknowledgementSet#6209
Open
san81 wants to merge 2 commits into
Open
Fix acknowledgement timeout handling in DefaultAcknowledgementSet#6209san81 wants to merge 2 commits into
san81 wants to merge 2 commits into
Conversation
…meout. Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
san81
commented
Oct 30, 2025
Comment on lines
-147
to
-150
| public Instant getExpiryTime() { | ||
| return expiryTime; | ||
| } | ||
|
|
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When acknowledgements time out in DefaultAcknowledgementSet, the callback is never invoked. The current implementation cancels the callback future on timeout but doesn't execute it, making caller unaware of expire event and giving the caller an option to take their required action.
The fix in this PR is to call the callback handler with
falsewhen acknowledgement set expires, which is kind of same as negative acknowledgment.The fix ensures that when an acknowledgement set times out, the callback is explicitly invoked with false
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.