Added throttle metric to S3 input stream#6245
Merged
Merged
Conversation
viquer
approved these changes
Nov 5, 2025
dlvenable
requested changes
Nov 5, 2025
| assertThat("Succeeded metric should be zero", emf.get("test-pipeline.s3-source.s3ObjectsSucceeded.count").asDouble(), equalTo(0.0)); | ||
| } | ||
|
|
||
| private void spyEMFOutput() { |
Member
There was a problem hiding this comment.
Can we use another Metric registry to avoid relying on stdout? This seems too brittle and intrusive.
Contributor
Author
There was a problem hiding this comment.
Sure thing. Using Prometheus scrape now.
mzurita-amz
force-pushed
the
s3-throttle-metric
branch
3 times, most recently
from
a9fa2f5 to
dc144ac
Compare
Signed-off-by: Manuel Mangas Zurita <mzurita@amazon.com>
mzurita-amz
force-pushed
the
s3-throttle-metric
branch
from
dc144ac to
6cbde4a
Compare
dlvenable
approved these changes
Nov 5, 2025
dlvenable
left a comment
dlvenable
left a comment
Member
There was a problem hiding this comment.
Thanks @mzurita-amz .
This is currently a draft. Would you like to open it? That will run the tests as well.
mzurita-amz
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
approved these changes
Nov 5, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.