Add lookback time adjustment for Office 365 source plugin partition e…#6266
Merged
graytaylor0 merged 1 commit intoNov 13, 2025
Merged
Conversation
alparish
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
san81
reviewed
Nov 13, 2025
| Instant sevenDaysAgo = Instant.now().minus(SEVEN_DAYS); | ||
| if (startTime.isBefore(sevenDaysAgo)) { | ||
| adjustedStartTime = sevenDaysAgo; | ||
| Instant lookBackHoursAgo = Instant.now().minus(Duration.ofHours(office365SourceConfig.getLookBackHours())); |
Collaborator
There was a problem hiding this comment.
Please add corresponding unit tests coverage!
alparish
force-pushed
the
Office365AdjustStartTime
branch
2 times, most recently
from
a5a66c4 to
72f6bec
Compare
…xecution Signed-off-by: Alekhya Parisha <aparisha@amazon.com>
alparish
force-pushed
the
Office365AdjustStartTime
branch
from
72f6bec to
9e3f781
Compare
san81
approved these changes
Nov 13, 2025
graytaylor0
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…xecution
What:
Example time window adjustment:
If current time is 9:30 AM and range is 4 days:
→ Ensures we fetch exactly 4 days of data, not 4 days + 30 minutes
Why:
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.