KCL metrics management through config#6361
Conversation
RashmiRam
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thank you @RashmiRam for this contribution. I have one comment.
Also, the DCO is failing. Please see the failing build for information and instructions on how to fix: https://github.com/opensearch-project/data-prepper/pull/6361/checks?check_run_id=58389994642
|
|
||
| @Getter | ||
| @JsonProperty("metrics") | ||
| private boolean metrics = false; |
There was a problem hiding this comment.
The existing configuration appears to include these metrics. So we must make the default consistent with the current behavior.
Also, we should express this as disabling rather than enabling. And we should clarify what metrics are disabled. There are more than KCL metrics, so the current name can be confusing.
I propose this configuration:
disable_client_metrics: true
or
disable_kcl_metrics: true
1.Added "metrics" config to disable/enable sending KCL metrics to cloudwatch 2.Default value is false. Signed-off-by: RashmiRam <ras.xena@gmail.com>
Signed-off-by: RashmiRam <ras.xena@gmail.com>
RashmiRam
force-pushed
the
kinesis-source-metrics-config
branch
from
dea83ca to
2a54f6b
Compare
Done. |
Signed-off-by: Rashmi <ras.xena@gmail.com>
Signed-off-by: RashmiRam <ras.xena@gmail.com>
|
@dlvenable Looks like these tests failures doesn't have anything to do with the changes that I have made. Can you please help me proceed further on this? |
2 participants
Description
1.Added "metrics" config to disable/enable sending KCL metrics to cloudwatch
2.Default value is false.
Issues Resolved
Resolves #6360
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.