Add TimeSeries based Service Map Processor#6389
Closed
san81 wants to merge 1 commit into
Closed
Conversation
Implements time-series based APM service map generation from OpenTelemetry traces using three-window sliding architecture with off-heap storage for scalability. Generates service relationship events and performance metrics.
san81
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
sb2k16 and
srikanthjg
as code owners
dlvenable
reviewed
Jan 6, 2026
| testImplementation project(':data-prepper-test:test-common') | ||
| } | ||
|
|
||
| test { |
| useJUnitPlatform() | ||
| } | ||
|
|
||
| jacocoTestReport { |
Member
There was a problem hiding this comment.
I don't think you need this either.
| @@ -0,0 +1,34 @@ | |||
| /* | |||
Member
There was a problem hiding this comment.
Please use the updated license headers:
| @JsonProperty(value = WINDOW_DURATION, defaultValue = "" + DEFAULT_WINDOW_DURATION) | ||
| @JsonPropertyDescription("Represents the fixed time window, in seconds, " + | ||
| "during which APM service map relationships are evaluated.") | ||
| private int windowDuration = DEFAULT_WINDOW_DURATION; |
Member
There was a problem hiding this comment.
This should be defined as a Duration. You can set a min and max using @DurationMin and @DurationMax.
| @JsonProperty(value = DB_PATH, defaultValue = DEFAULT_DB_PATH) | ||
| @JsonPropertyDescription("Represents folder path for creating database files storing transient data off heap memory" + | ||
| "when processing APM service-map data.") | ||
| private String dbPath = DEFAULT_DB_PATH; |
Member
There was a problem hiding this comment.
I wonder if this is the right way to go. Why would somebody need to configure this path? I think ideally, this is part of the data-prepper directory structure and is automatically defined.
| @JsonClassDescription("The <code>otel_apm_service_map</code> processor uses OpenTelemetry data to create APM service map " + | ||
| "relationships for visualization, generating ServiceDetails and ServiceRemoteDetails events.") | ||
| public class OtelApmServiceMapProcessorConfig { | ||
| private static final String WINDOW_DURATION = "window_duration"; |
Member
There was a problem hiding this comment.
I don't think there is any value to using these constants. Just put the literal value in the @JsonProperty. Some older implementations did this to support migration from legacy concepts.
Member
|
This was completed in #6479 and this PR is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements time-series based APM service map generation from OpenTelemetry traces using three-window sliding architecture with off-heap storage for scalability. Generates service relationship events and performance metrics.
Description
[Describe what this change achieves]
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.