GitHub Action to verify that newly added files have the license header.#6392
Merged
dlvenable merged 1 commit intoJan 6, 2026
Merged
Conversation
This includes Python scripts for validation as well as a GitHub Action that runs them and comments on PRs if license headers are missing. Signed-off-by: David Venable <dlv@amazon.com>
8bb1808 to
ec20443
Compare
san81
approved these changes
Jan 6, 2026
kkondaka
approved these changes
Jan 6, 2026
wandna-amazon
pushed a commit
to wandna-amazon/data-prepper
that referenced
this pull request
Jan 8, 2026
…r. (opensearch-project#6392) This includes Python scripts for validation as well as a GitHub Action that runs them and comments on PRs if license headers are missing. Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: Nathan Wand <wandna@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…r. (opensearch-project#6392) This includes Python scripts for validation as well as a GitHub Action that runs them and comments on PRs if license headers are missing. Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…r. (opensearch-project#6392) This includes Python scripts for validation as well as a GitHub Action that runs them and comments on PRs if license headers are missing. Signed-off-by: David Venable <dlv@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…r. (opensearch-project#6392) This includes Python scripts for validation as well as a GitHub Action that runs them and comments on PRs if license headers are missing. Signed-off-by: David Venable <dlv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have many PRs without license headers or the old two-line license header. This PR adds a check for new files to spot check for the license headers.
If it finds files with missing headers, it will create a GitHub comment listing all the files. It also directs authors to the relevant license header documentation.
I considered Checkstyle/Spotless changes, but these will be hard to manage until we get it all cleaned up. For example, I have #6390 open to fix just a small set and it is already a large PR. The GHA approach is a good way to keep pushing forward and catching the issues before code is merged. We can continue to backfill with more certainty of not getting new files without the headers.
You can see some actual runs here:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.