Add check in pipeline transformation to make sure there is atleast one pipeline with a valid external source#6397
Conversation
kkondaka
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
| } | ||
|
|
||
| @Test | ||
| void testPipelineConfigWithOnlyHeadlessPipelines() { |
There was a problem hiding this comment.
Do we have an existing test for a valid config with a headless pipeline?
There was a problem hiding this comment.
@dlvenable we have data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/integration/DLQHeadlessPipelinesIT.java and data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/integration/ForwardingHeadlessPipelinesIT.java
There was a problem hiding this comment.
@kkondaka , We should have a unit test in this code that ensures that a valid config with a headless pipeline still passes. Pushing this validation to the integration tests is not as ideal since those have more possible failure cases.
…e pipeline with a valid external source Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka
force-pushed
the
pipeline-transform-check
branch
from
ce64091 to
cdeaf17
Compare
| } | ||
|
|
||
| @Test | ||
| void testPipelineConfigWithOnlyHeadlessPipelines() { |
There was a problem hiding this comment.
@kkondaka , We should have a unit test in this code that ensures that a valid config with a headless pipeline still passes. Pushing this validation to the integration tests is not as ideal since those have more possible failure cases.
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
3 participants
Description
Add check in pipeline transformation to make sure there is atleast one pipeline with a valid external source. Currently, we allow pipeline config with all headless pipelines or and pipeline connectors as source. This change validates the config to make sure there is at least one pipeline with external source
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.