Add kafka buffer backward compatibility test#6406
Merged
graytaylor0 merged 2 commits intoJan 15, 2026
Merged
Conversation
graytaylor0
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
force-pushed
the
KafkabufferImprovements
branch
3 times, most recently
from
e17dfda to
273b69c
Compare
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
KafkabufferImprovements
branch
from
273b69c to
55b0a31
Compare
dlvenable
requested changes
Jan 15, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Nice work. This looks like it will work well.
At a high level, we should improve the name:
- The naming doesn't imply that this is the Kafka buffer. We also support a source and a nascent sink.
- Do we really need to explicitly use "backward" as we have not forward compatibility implied?
Maybe call the project kafka-buffer-compatibility and name the task kafkaBufferCompatibilityTest.
| * by writing data with a released version and reading with the current build. | ||
| */ | ||
|
|
||
| def RELEASED_VERSION = project.hasProperty('backwardCompatVersion') ? |
Member
There was a problem hiding this comment.
Let's avoid abbreviations like "compat". I think releasedVersion would also be a better name for the property.
-PreleasedVersion=2.13.0
But, we can also use backwardCompatibilityVersion.
| buffer: | ||
| kafka: | ||
| topics: | ||
| - name: backward-compat-test-topic |
Member
There was a problem hiding this comment.
backward-compatibility-test-topic
| kafka: | ||
| topics: | ||
| - name: backward-compat-test-topic | ||
| group_id: backward-compat-reader-group |
Member
There was a problem hiding this comment.
backward-compatibility-reader-group
| username: "admin" | ||
| password: "admin" | ||
| insecure: true | ||
| index: "backward-compat-test-index" |
Member
There was a problem hiding this comment.
kafka-backward-compatibility-test-index
Since this is an OpenSearch domain, it is probably best to scope with kafka as well.
| } | ||
|
|
||
| // Clean up tasks - remove any existing containers/networks before starting | ||
| tasks.register('cleanupKafkaBackwardCompatTest') { |
Member
There was a problem hiding this comment.
Suggested change
| tasks.register('cleanupKafkaBackwardCompatTest') { | |
| tasks.register('cleanupKafkaBackwardCompatibilityTest') { |
| 3. Both messages appear in OpenSearch with correct content | ||
| 4. Test completes with ✅ SUCCESS message | ||
|
|
||
| ## CI/CD Integration |
| */ | ||
|
|
||
| def RELEASED_VERSION = project.hasProperty('backwardCompatVersion') ? | ||
| project.getProperty('backwardCompatVersion') : '2.10.0' |
Member
There was a problem hiding this comment.
Why not 2.13.0?
Also, we should have 2 as an alias for the last released 2.x Data Prepper. That may be a better default.
Member
Author
There was a problem hiding this comment.
I'm going to use '2' so it always gets the latest release
| private static final int WRITER_HTTP_PORT = 2021; | ||
| private static final String TEST_INDEX_NAME = "backward-compat-test-index"; | ||
| private static final String MESSAGE_KEY = "message"; | ||
| private static final String TEST_VALUE_1 = "test-record-1-from-released-version"; |
Member
There was a problem hiding this comment.
We should be able to generate these values in @BeforeEach instead.
You can make them somewhat random as well:
testValue1 = "test-record-1-from-released-version" + UUID.randomUUID.toString();
| import com.linecorp.armeria.common.MediaType; | ||
| import com.linecorp.armeria.common.RequestHeaders; | ||
| import com.linecorp.armeria.common.SessionProtocol; | ||
| import org.junit.Assert; |
Member
There was a problem hiding this comment.
No JUnit 4. Please replace with JUnit 5.
| builder.withUsername("admin"); | ||
| builder.withPassword("admin"); | ||
| builder.withInsecure(true); | ||
| final AwsCredentialsSupplier awsCredentialsSupplier = mock(AwsCredentialsSupplier.class); |
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
KafkabufferImprovements
branch
from
cdbdac1 to
b0b5fa6
Compare
dlvenable
approved these changes
Jan 15, 2026
kkondaka
approved these changes
Jan 15, 2026
ashrao94
pushed a commit
to ashrao94/data-prepper
that referenced
this pull request
Jan 22, 2026
Signed-off-by: Taylor Gray <tylgry@amazon.com>
san81
pushed a commit
to san81/data-prepper
that referenced
this pull request
Jan 27, 2026
Signed-off-by: Taylor Gray <tylgry@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
Signed-off-by: Taylor Gray <tylgry@amazon.com> Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
Signed-off-by: Taylor Gray <tylgry@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
Signed-off-by: Taylor Gray <tylgry@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds an end to end test to data prepper for testing kafka buffer backward compatibility. The steps of the test are
delayso that those records are not consumed from the bufferCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.