Remove SingleThread annotation from Drop Events Processor#6417
Merged
dlvenable merged 1 commit intoFeb 4, 2026
Conversation
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
reviewed
Feb 3, 2026
| import java.util.Collections; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| @SingleThread |
Member
There was a problem hiding this comment.
Is there any context for why this was added in the first place?
Member
There was a problem hiding this comment.
We originally added this annotation because the expression evaluator was not thread safe. That was resolved in #1840. So this processor doesn't need to have per-thread implementations.
graytaylor0
approved these changes
Feb 3, 2026
dlvenable
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove SingleThread annotation from Drop Events Processor. There is no state maintained in the processor to use SingleThread annotation. Multiple worker threads should be able to use one processor object.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.