Fixes a false reporting bug for the invalidEventHandles counter#6420
Merged
dlvenable merged 1 commit intoJan 22, 2026
Merged
Conversation
…r. This metric was being counted for any event that is not a default event (ie. for aggregate events). This would happen even if there is no need to discard the event. This change should count this when aggregate events should be released but are not. We probably need some deeper investigation into how we can properly release aggregate events. But, for now this metric will be more accurate. Also improves some code to reduce unnecessary variables, use final modifiers, and better legibility. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
approved these changes
Jan 22, 2026
san81
approved these changes
Jan 22, 2026
san81
pushed a commit
to san81/data-prepper
that referenced
this pull request
Jan 27, 2026
…search-project#6420) Fixes a bug with the invalidEventHandles counter in the PipelineRunner. This metric was being counted for any event that is not a default event (ie. for aggregate events). This would happen even if there is no need to discard the event. This change should count this when aggregate events should be released but are not. We probably need some deeper investigation into how we can properly release aggregate events. But, for now this metric will be more accurate. Also improves some code to reduce unnecessary variables, use final modifiers, and better legibility. Signed-off-by: David Venable <dlv@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…search-project#6420) Fixes a bug with the invalidEventHandles counter in the PipelineRunner. This metric was being counted for any event that is not a default event (ie. for aggregate events). This would happen even if there is no need to discard the event. This change should count this when aggregate events should be released but are not. We probably need some deeper investigation into how we can properly release aggregate events. But, for now this metric will be more accurate. Also improves some code to reduce unnecessary variables, use final modifiers, and better legibility. Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…search-project#6420) Fixes a bug with the invalidEventHandles counter in the PipelineRunner. This metric was being counted for any event that is not a default event (ie. for aggregate events). This would happen even if there is no need to discard the event. This change should count this when aggregate events should be released but are not. We probably need some deeper investigation into how we can properly release aggregate events. But, for now this metric will be more accurate. Also improves some code to reduce unnecessary variables, use final modifiers, and better legibility. Signed-off-by: David Venable <dlv@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…search-project#6420) Fixes a bug with the invalidEventHandles counter in the PipelineRunner. This metric was being counted for any event that is not a default event (ie. for aggregate events). This would happen even if there is no need to discard the event. This change should count this when aggregate events should be released but are not. We probably need some deeper investigation into how we can properly release aggregate events. But, for now this metric will be more accurate. Also improves some code to reduce unnecessary variables, use final modifiers, and better legibility. Signed-off-by: David Venable <dlv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug with the invalidEventHandles counter in the PipelineRunner. This metric was being counted for any event that is not a default event (ie. for aggregate events). This would happen even if there is no need to discard the event. This change should count this when aggregate events should be released but are not. We probably need some deeper investigation into how we can properly release aggregate events. But, for now this metric will be more accurate.
Also improves some code to reduce unnecessary variables, use final modifiers, and better legibility.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.