Sending metric metadata along with metrics so the PrometheusSink.#6422
Draft
san81 wants to merge 2 commits into
Draft
Sending metric metadata along with metrics so the PrometheusSink.#6422san81 wants to merge 2 commits into
san81 wants to merge 2 commits into
Conversation
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
data-prepper sending metrics to AMP, but when getting metrics names, metadata API returning null. This PR is fixing that by creating the metadata from the metrics and adding it to the Prometheus Timeseries protobuf object.
but this API returns empty before this fix. But now it returns the metadata.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.