Fix invalid document version events still included in bulk requests #6601#6645
Merged
oeyh merged 1 commit intoMar 18, 2026
Conversation
Keyur-S-Patel
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Keyur-S-Patel
force-pushed
the
fix/6601-invalid-version-still-in-bulk-request
branch
from
c935360 to
506ee95
Compare
graytaylor0
approved these changes
Mar 17, 2026
graytaylor0
left a comment
graytaylor0
left a comment
Member
There was a problem hiding this comment.
Thanks for making this change!
…pensearch-project#6601) Events with invalid document_version values are correctly sent to the DLQ but were still being added to the OpenSearch bulk request. Added continue statements after the NumberFormatException and RuntimeException catch blocks in doOutput() to skip the rest of the loop iteration for failed events. Added unit tests to verify events with invalid versions are not added to the bulk request. Signed-off-by: Keyur-S-Patel <keyurpatel.opensource@gmail.com>
Keyur-S-Patel
force-pushed
the
fix/6601-invalid-version-still-in-bulk-request
branch
from
506ee95 to
63d290a
Compare
oeyh
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using external versioning with
document_versionanddocument_version_typein the OpenSearch sink, events with invalid version fields were correctly sent to the DLQ but then still included in the bulk request. This change addscontinuestatements after theNumberFormatExceptionandRuntimeExceptioncatch blocks indoOutput()so that events with invalid versions are skipped from the bulk request after being routed to the DLQ. This matches the existing pattern used for invalid index names.Issues Resolved
Resolves #6601
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/data-prepper/blob/main/CONTRIBUTING.md).