S3 sink server-side encryption with KMS#6655
Merged
Merged
Conversation
Adds new configuration for encryption options in the S3 sink. Allow configuring a custom KMS key for S3 server-side encryption. Support SSE-KMS and DSSE-KMS. Resolves opensearch-project#6528. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
KarstenSchnitter,
dinujoh,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
oeyh
reviewed
Mar 20, 2026
Comment on lines
+29
to
32
| final BucketOwnerProvider bucketOwnerProvider, | ||
| final ServerSideEncryptionConfig serverSideEncryptionConfig) { | ||
| return new MultipartBuffer(new S3OutputStream(s3Client, bucketSupplier, keySupplier, defaultBucket, bucketOwnerProvider)); | ||
| } |
Collaborator
There was a problem hiding this comment.
This serverSideEncryptionConfig is not passed down to MultipartBuffer, so data will not be encrypted as configured when using MultipartBuffer.
Collaborator
|
Build is also failing due to unused imports |
Signed-off-by: David Venable <dlv@amazon.com>
sb2k16
approved these changes
Mar 20, 2026
oeyh
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new configuration for encryption options in the S3 sink. Allow configuring a custom KMS key for S3 server-side encryption. Support SSE-KMS and DSSE-KMS.
Includes integration test updates to verify. I ran these locally.
Issues Resolved
Resolves #6528.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.