Skip to content

Fix duplicate _seconds suffix in APM latency metric name #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graytaylor0 merged 1 commit into from
Mar 20, 2026
Merged

Fix duplicate _seconds suffix in APM latency metric name #6657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data-prepper-plugins/otel-apm-service-map-processor/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ The processor generates time-series metrics as JacksonMetric events:
| `request` | Sum (monotonic) | `1` | Number of requests |
| `error` | Sum (monotonic) | `1` | Number of error requests (HTTP 4xx) |
| `fault` | Sum (monotonic) | `1` | Number of fault requests (HTTP 5xx or ERROR status) |
| `latency_seconds` | Histogram | `s` | Request latency distribution |
| `latency` | Histogram | `s` | Request latency distribution |

**Histogram Bucket Boundaries:**
`[0.0, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0]`
Expand Down
2 changes: 1 addition & 1 deletion ...ch/dataprepper/plugins/processor/otel_apm_service_map/utils/ApmServiceMapMetricsUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ public static List<JacksonMetric> createMetricsFromAggregatedState(final Map<Met
// Create latency_seconds histogram (only if there are duration samples)
if (!state.getLatencyDurations().isEmpty()) {
metrics.add(createJacksonStandardHistogram(
"latency_seconds",
"latency",
"Request latency in seconds",
state.getLatencyDurations(),
metricKey.getLabels(),
Expand Down
2 changes: 1 addition & 1 deletion ...ch/dataprepper/plugins/processor/otel_apm_service_map/OTelApmServiceMapProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,7 @@ void testDecorateSpansInTraceWithEphemeralStorage() {
event = resultList.get(2).getData();
assertThat(event.get("name", String.class), equalTo("fault"));
event = resultList.get(3).getData();
assertThat(event.get("name", String.class), equalTo("latency_seconds"));
assertThat(event.get("name", String.class), equalTo("latency"));
event = resultList.get(4).getData();
String sourceNodeName4 = event.get("sourceNode/keyAttributes/name", String.class);
event = resultList.get(5).getData();
Expand Down
6 changes: 3 additions & 3 deletions ...ataprepper/plugins/processor/otel_apm_service_map/utils/ApmServiceMapMetricsUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ void testCreateMetricsFromAggregatedState_EmptyLatencyDurations() {
List<JacksonMetric> metrics = ApmServiceMapMetricsUtil.createMetricsFromAggregatedState(metricsStateByKey);

// Then
assertEquals(3, metrics.size()); // Only request, error, fault (no latency_seconds)
assertEquals(3, metrics.size()); // Only request, error, fault (no latency)
}

@Test
Expand Down Expand Up @@ -521,7 +521,7 @@ void testCreateMetricsFromAggregatedState_Success() {
List<JacksonMetric> metrics = ApmServiceMapMetricsUtil.createMetricsFromAggregatedState(metricsStateByKey);

// Then
assertEquals(4, metrics.size()); // request, error, fault, latency_seconds
assertEquals(4, metrics.size()); // request, error, fault, latency

// Verify metric names
List<String> metricNames = metrics.stream()
Expand All @@ -530,7 +530,7 @@ void testCreateMetricsFromAggregatedState_Success() {
assertTrue(metricNames.contains("request"));
assertTrue(metricNames.contains("error"));
assertTrue(metricNames.contains("fault"));
assertTrue(metricNames.contains("latency_seconds"));
assertTrue(metricNames.contains("latency"));
}

@Test
Expand Down
Loading