Enable kafka sink integration tests as a github workflow action#6751
Merged
Conversation
graytaylor0
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
force-pushed
the
KafkaSinkInteg
branch
from
39252de to
3affe7d
Compare
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
KafkaSinkInteg
branch
from
3affe7d to
91dcd7e
Compare
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
dlvenable
requested changes
Apr 13, 2026
| import static org.mockito.Mockito.when; | ||
|
|
||
|
|
||
| /** |
Member
There was a problem hiding this comment.
I don't think we need this comment.
Member
Author
There was a problem hiding this comment.
I added this comment to force the tests to run as github action since it only runs when a change is detected. Is there a manual way to run a github action?
| if (!records.isEmpty() && records.count() > 0) { | ||
| List<JsonNode> consumed = new ArrayList<>(); | ||
| int maxRetries = 15; | ||
| while (consumed.size() < expectedRecords.size() && maxRetries-- > 0) { |
Member
There was a problem hiding this comment.
Can we use Awaitility instead?
| topicConfig = mock(TopicProducerConfig.class); | ||
| when(topicConfig.getName()).thenReturn(testTopic); | ||
| when(topicConfig.getSerdeFormat()).thenReturn(MessageFormat.JSON); | ||
| when(topicConfig.isCreateTopic()).thenReturn(false); |
Member
There was a problem hiding this comment.
I think we will need this for the GitHub Actions to pass. Unless there is some code in this test that creates the topic.
Member
Author
There was a problem hiding this comment.
The topic is created in the test code separately, so the sink plugin does not create the topic, just the test.
| created.set(false); | ||
| } | ||
| while (created.get() != false) { | ||
| while (!created.get()) { |
Member
There was a problem hiding this comment.
Use Awaitility. Also this has not stopping point during failures.
Signed-off-by: Taylor Gray <tylgry@amazon.com>
dinujoh
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabled kafka sink integration tests as a github workflow action
Locally ran kafka source and sink integration tests to confirm they are passing. The github actions for this PR still fail due to the old integ test code running for kafka source
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.