Extract shared Prometheus metric utilities for output consistency #6830
Merged
kkondaka merged 3 commits intoMay 11, 2026
Merged
Conversation
…-parser consistency test Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
srikanthpadakanti
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
reviewed
May 8, 2026
…w feedback Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
dlvenable
approved these changes
May 11, 2026
kkondaka
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extractServiceName,stripCounterSuffix,parseLeValue,parseQuantileValue) into sharedPrometheusMetricUtilsAGGREGATION_TEMPORALITY_CUMULATIVEconstantPrometheusOutputConsistencyTest— feeds same metric through both parsers, asserts identical outputPrometheusScrapeConfig.isTargetUrlSchemeValid()and decimal timestamp parsingIssues Resolved
Resolves #6766
#6766
Context
Per #6766, @dlvenable asked for common code to ensure output consistency between remote write and scrape parsers.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.