Skip to content

Support PluginConfigVariable for Confluence/Jira bearer token. #6856

Open
srikanthpadakanti wants to merge 5 commits into
opensearch-project:mainfrom
srikanthpadakanti:confluence-plugin-config-variable-6844
Open

Support PluginConfigVariable for Confluence/Jira bearer token. #6856
srikanthpadakanti wants to merge 5 commits into
opensearch-project:mainfrom
srikanthpadakanti:confluence-plugin-config-variable-6844

Conversation

@srikanthpadakanti
Copy link
Copy Markdown
Collaborator

Description

Change bearer_token field in AuthenticationConfig from String to PluginConfigVariable to enable reading credentials from external secrets managers (e.g., AWS Secrets Manager). The renewCredentials() method in AtlassianBearerTokenAuthConfig now calls refresh() on the variable so externally rotated secrets are picked up on next use.

Issues Resolved

Resolves #6844
#6844

Check List

  • [ X ] New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
  • [ X ] New functionality has javadoc added
  • [ X ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…anager integration

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Copy link
Copy Markdown
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srikanthpadakanti for this contribution!

@dlvenable dlvenable marked this pull request as draft May 19, 2026 16:18
@dlvenable dlvenable marked this pull request as ready for review May 19, 2026 16:18
@srikanthpadakanti
Copy link
Copy Markdown
Collaborator Author

srikanthpadakanti commented May 21, 2026

Noticed AtlassianOauthConfig.java have the same unsafe cast pattern on getAccessToken().getValue() and getRefreshToken().getValue(). I'll fix those in a follow-up PR to keep this one scoped to bearer token only.

…date token validation into helper method

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Copy link
Copy Markdown
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srikanthpadakanti for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PluginConfigVariable for Confluence/Jira bearer token to enable secrets manager integration

2 participants