Replace unsafe String casts with instanceof check in AtlassianOauthConfig #6875
Open
srikanthpadakanti wants to merge 1 commit into
Open
Replace unsafe String casts with instanceof check in AtlassianOauthConfig #6875srikanthpadakanti wants to merge 1 commit into
srikanthpadakanti wants to merge 1 commit into
Conversation
srikanthpadakanti
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
srikanthpadakanti
changed the title
1 task
srikanthpadakanti
force-pushed
the
fix-unsafe-oauth2-cast-6874
branch
from
690c7a9 to
704acd2
Compare
…nfig Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
srikanthpadakanti
force-pushed
the
fix-unsafe-oauth2-cast-6874
branch
from
704acd2 to
1a43376
Compare
Collaborator
Author
|
Hello @dlvenable Please review |
dlvenable
approved these changes
May 21, 2026
Collaborator
Author
|
Hello @kkondaka Can you please take a look at it when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace unsafe
(String)casts onPluginConfigVariable.getValue()inAtlassianOauthConfigwith aresolveStringValue()helper that usesinstanceofcheck andtoString()fallback.Issues Resolved
Resolves #6874
#6874
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.