Fix opensearch_api _bulk endpoint to return proper JSON response#6878
Open
divakarsingh wants to merge 1 commit into
Open
Fix opensearch_api _bulk endpoint to return proper JSON response#6878divakarsingh wants to merge 1 commit into
divakarsingh wants to merge 1 commit into
Conversation
divakarsingh
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16,
srikanthjg and
srikanthpadakanti
as code owners
The _bulk endpoint returned an empty HTTP 200 with no body. Clients using
RestHighLevelClient (Flink, Logstash, opensearch-py) expect a JSON response
with {took, errors, items[]} and fail with 'Unable to parse response body'.
This adds buildBulkResponse() which constructs a response matching the
OpenSearch Bulk API format, iterating through the parsed action/doc pairs
and producing one item per action.
Resolves opensearch-project#6877
Signed-off-by: Divakar Pratap Singh <divakar.p.singh@gmail.com>
divakarsingh
force-pushed
the
fix/bulk-response-body
branch
from
7236d5b to
91d5147
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
_bulkendpoint returned an empty HTTP 200 with no body. Clients usingRestHighLevelClient(Flink, Logstash, opensearch-py)expect a JSON response with
{took, errors, items[]}and fail with "Unable to parse response body".This adds
buildBulkResponse()which constructs a response matching the OpenSearch Bulk API format.Issues Resolved
Resolves #6877
Check List