Log uncaught errors in S3 scan worker to prevent silent thread death#6890
Merged
oeyh merged 1 commit intoMay 29, 2026
Merged
Conversation
Signed-off-by: Hai Yan <oeyh@amazon.com>
Zhangxunmt
approved these changes
May 29, 2026
divbok
approved these changes
May 29, 2026
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 1, 2026
…pensearch-project#6890) Signed-off-by: Hai Yan <oeyh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the S3 scan worker thread encounters an uncaught
Error(e.g.,NoSuchMethodErrordue to dependency version mismatch), the thread dies silently because:ScanObjectWorker.run()only catchesException, notErrorExecutorService.submit()swallows allThrowableinto theFuturewithout loggingThis results in the S3 scan pipeline silently stopping — no errors in logs, no stderr output — making it extremely difficult to diagnose. RDS source pipelines were affected by this because they transform to S3 scan pipelines.
Changes
Wrap the scan worker execution in a try/catch for
Throwableto ensure any uncaught errors are logged before the thread exits.Testing
sdk-core-2.44+retries-spi-2.39) that theNoSuchMethodErroris now loggedIssues Resolved
N/A
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.