Skip to content

Log uncaught errors in S3 scan worker to prevent silent thread death #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oeyh merged 1 commit into from
May 29, 2026
Merged

Log uncaught errors in S3 scan worker to prevent silent thread death #6890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...s/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/S3ScanService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
import org.opensearch.dataprepper.plugins.source.s3.configuration.S3ScanBucketOption;
import org.opensearch.dataprepper.plugins.source.s3.configuration.S3ScanBucketOptions;
import org.opensearch.dataprepper.plugins.source.s3.configuration.S3ScanProcessingCondition;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.time.Duration;
import java.time.LocalDateTime;
Expand All @@ -31,6 +33,7 @@
* objects and spawn a thread {@link S3SelectObjectWorker}
*/
public class S3ScanService {
private static final Logger LOG = LoggerFactory.getLogger(S3ScanService.class);
static final long SHUTDOWN_TIMEOUT = 30L;

private final S3SourceConfig s3SourceConfig;
Expand Down Expand Up @@ -106,7 +109,13 @@ public void start() {
acknowledgementSetManager, s3ObjectDeleteWorker, backOffMs, pluginMetrics, conditionEvaluator,
bucketProcessingConditionsMap);
workers.add(scanObjectWorker);
executorService.submit(new Thread(scanObjectWorker));
executorService.submit(() -> {
try {
scanObjectWorker.run();
} catch (final Throwable t) {
LOG.error("S3 scan worker terminated due to uncaught error", t);
}
});
}
}

Expand Down
Loading