Detect zstd compressed objects in automatic compression mode#6909
Open
bagmarnikhil wants to merge 1 commit into
Open
Detect zstd compressed objects in automatic compression mode#6909bagmarnikhil wants to merge 1 commit into
bagmarnikhil wants to merge 1 commit into
Conversation
CompressionOption.fromFileName() backs the "automatic" compression option for the S3 source (both SQS-notification and scan paths) and the S3 enrich processor. It only recognized ".gz" (GZIP) and ".snappy" (SNAPPY) and silently fell back to NONE for everything else, so zstd-compressed objects were passed to the codec without decompression and failed to parse — even though ZSTD is a valid CompressionOption with a working ZstdDecompressionEngine already wired in. Map the ".zst" (canonical, per the zstd CLI and RFC 8478) and ".zstd" (informal alternate spelling) extensions to CompressionOption.ZSTD so automatic detection decompresses these objects correctly. Behavior is unchanged unless a user explicitly configures compression: automatic. Add unit tests covering both extensions. Signed-off-by: Nikhil Bagmar <nikhilbagmar73@gmail.com>
bagmarnikhil
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16,
srikanthjg and
srikanthpadakanti
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CompressionOption.fromFileName()backs theautomaticcompression option for the S3 source (both the SQS-notification and scan paths) and the S3 enrich processor. It only recognized.gz(GZIP) and.snappy(SNAPPY) and silently fell back toNONEfor everything else, so zstd-compressed objects were passed to the codec without decompression and failed to parse — even though
ZSTDis a validCompressionOptionwith a workingZstdDecompressionEnginealready wired in.This change maps the
.zst(canonical, per the zstd CLI and RFC 8478) and.zstd(informal alternate spelling) extensions toCompressionOption.ZSTD, so automatic detection decompresses these objects correctly.Behavior is unchanged unless a user explicitly configures
compression: automatic; the shipped default isNONE. No new compression engine or dependency is introduced — the fix reuses the existingZstdDecompressionEngine. Because the fix livesin the shared
commonenum, all three consumers (s3-source SQS path, s3-source scan path, and s3-enrich-processor) are corrected at once.Unit tests were added covering both the
.zstand.zstdextensions.Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.