Fix bug in s3 eventbridge notification where a new field was introduced#6932
Merged
Conversation
divbok
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16,
srikanthjg and
srikanthpadakanti
as code owners
dinujoh
approved these changes
Jun 17, 2026
dinujoh
reviewed
Jun 17, 2026
| return detail; | ||
| } | ||
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) |
Member
There was a problem hiding this comment.
event-version – The event schema version in the form major.minor (for example, 1.0). The major version is incremented for backward-incompatible changes to the event structure. The minor version is incremented for backward-compatible changes, such as adding new fields or introducing new event types.
We should support even-version as followup as the schema can have breaking change for major version changes.
Signed-off-by: Divyansh Bokadia <dbokadia@amazon.com>
graytaylor0
approved these changes
Jun 17, 2026
dinujoh
approved these changes
Jun 17, 2026
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 1, 2026
…ed (opensearch-project#6932) Signed-off-by: Divyansh Bokadia <dbokadia@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWS S3 recently added a new
event-versionfield to the EventBridge notification detail schema. This causes Jackson deserialization failures inS3EventBridgeNotificationDetailAdded
@JsonIgnoreProperties(ignoreUnknown = true)to the Detail class so that new or unexpected fields in the EventBridge notification are safely ignored. Addedevent-versionto the schemaCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.