Add lasttoken and none pooling modes to text embedding model docs#12390
Open
aneesh-db wants to merge 1 commit into
Open
Add lasttoken and none pooling modes to text embedding model docs#12390aneesh-db wants to merge 1 commit into
aneesh-db wants to merge 1 commit into
Conversation
Document the new lasttoken and none pooling_mode values supported by the ml-commons text embedding model registration API. Closes opensearch-project#12076 Closes opensearch-project#12075 Signed-off-by: Aneesh Nema <aneesh.nema@databricks.com>
aneesh-db
requested review from
cwperks,
dlvenable,
epugh,
kolchfa-aws,
mgodwan,
peterzhuamazon and
sumobrian
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). |
Collaborator
|
@rithinpullela Could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents two new
pooling_modevalues supported by the ml-commons text embedding model registration API:lasttoken— uses the last non-padding token's embedding; useful for decoder-only models (e.g., Qwen3-Embedding) where the final token captures cumulative context through causal attention.none— uses pre-pooled output from the model directly without additional pooling, suitable for models that already provide pooled embeddings (e.g.,sentence_embedding,pooler_output).Issues Resolved
Closes #12076
Closes #12075
Related ml-commons PRs
Version
3.4
Checklist