Skip to content

Commit 656223b

Browse files
committed
Fix JsonData deserialization
Signed-off-by: Andriy Redko <drreta@gmail.com>
1 parent 2f6c34d commit 656223b

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

java-client/src/main/java/org/opensearch/client/json/JsonData.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,5 +108,7 @@ static JsonData from(JsonParser parser, JsonpMapper mapper) {
108108
return of(parser.getValue(), mapper);
109109
}
110110

111-
JsonpDeserializer<JsonData> _DESERIALIZER = JsonpDeserializer.of(EnumSet.allOf(JsonParser.Event.class), JsonData::from);
111+
JsonpDeserializer<JsonData> _DESERIALIZER = JsonpDeserializer.of(EnumSet.allOf(JsonParser.Event.class), (parser, mapper, event) -> {
112+
return of(parser.getValue(), mapper);
113+
});
112114
}

java-client/src/test/java11/org/opensearch/client/opensearch/integTest/AbstractRequestIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
import org.opensearch.client.opensearch._types.Time;
5050
import org.opensearch.client.opensearch._types.aggregations.Aggregate;
5151
import org.opensearch.client.opensearch._types.aggregations.HistogramAggregate;
52-
import org.opensearch.client.opensearch._types.aggregations.SingleBucketAggregateBase;
52+
import org.opensearch.client.opensearch._types.aggregations.MultiTermsBucket;
5353
import org.opensearch.client.opensearch._types.analysis.Analyzer;
5454
import org.opensearch.client.opensearch._types.analysis.CustomAnalyzer;
5555
import org.opensearch.client.opensearch._types.analysis.ShingleTokenFilter;
@@ -478,8 +478,8 @@ public void testSubAggregation() throws IOException {
478478
SearchResponse<Product> searchResponse = javaClient().search(searchRequest, Product.class);
479479

480480
Aggregate prices = searchResponse.aggregations().get("price")._get().toAggregate();
481-
assertEquals(1, prices.dterms().buckets().array().get(0).to(SingleBucketAggregateBase.class).docCount());
482-
assertEquals(1, prices.dterms().buckets().array().get(1).to(SingleBucketAggregateBase.class).docCount());
481+
assertEquals(1, prices.dterms().buckets().array().get(0).to(MultiTermsBucket.class).docCount());
482+
assertEquals(1, prices.dterms().buckets().array().get(1).to(MultiTermsBucket.class).docCount());
483483

484484
// We've set "size" to zero
485485
assertEquals(0, searchResponse.hits().hits().size());

java-client/src/test/java11/org/opensearch/client/opensearch/integTest/AbstractSearchTemplateRequestIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import org.opensearch.client.json.JsonData;
1717
import org.opensearch.client.opensearch._types.BuiltinScriptLanguage;
1818
import org.opensearch.client.opensearch._types.Refresh;
19-
import org.opensearch.client.opensearch._types.aggregations.SingleBucketAggregateBase;
19+
import org.opensearch.client.opensearch._types.aggregations.MultiTermsBucket;
2020
import org.opensearch.client.opensearch._types.mapping.Property;
2121
import org.opensearch.client.opensearch.core.PutScriptRequest;
2222
import org.opensearch.client.opensearch.core.SearchTemplateResponse;
@@ -85,8 +85,8 @@ public void testTemplateSearchAggregations() throws Exception {
8585
assertEquals(1, searchResponse.aggregations().size());
8686
var buckets = searchResponse.aggregations().get("test-aggs").sterms().buckets().array();
8787
assertEquals(2, buckets.size());
88-
assertEquals(2, buckets.get(0).to(SingleBucketAggregateBase.class).docCount());
89-
assertEquals(2, buckets.get(1).to(SingleBucketAggregateBase.class).docCount());
88+
assertEquals(2, buckets.get(0).to(MultiTermsBucket.class).docCount());
89+
assertEquals(2, buckets.get(1).to(MultiTermsBucket.class).docCount());
9090

9191
}
9292

0 commit comments

Comments
 (0)