Return checkHasApiPermission as a method that can be used by other dashboards-plugins#2392
Draft
cwperks wants to merge 1 commit into
Draft
Return checkHasApiPermission as a method that can be used by other dashboards-plugins#2392cwperks wants to merge 1 commit into
cwperks wants to merge 1 commit into
Conversation
…shboards-plugins Signed-off-by: Craig Perkins <craig5008@gmail.com>
7 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
==========================================
- Coverage 71.59% 71.57% -0.03%
==========================================
Files 101 101
Lines 3010 3011 +1
Branches 529 511 -18
==========================================
Hits 2155 2155
- Misses 699 700 +1
Partials 156 156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion OSD core PR: opensearch-project/OpenSearch-Dashboards#11620
Example usage in a dashboards-plugin (in this case reporting): cwperks/dashboards-reporting#2
This PR returns checkHasApiPermission from security-dashboards-plugin for use by other dashboards plugins to conditionally hide/reveal from the main menu. The intended consumer of this is a new dashboards-job-scheduler plugin.
Category
Enhancement
Issues Resolved
Related to opensearch-project/security#5635, but limited in scope to hiding/revealing a menu item only if the logged in user is a security admin.
Testing
See companion PRs:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.