Disable multi-tenancy in multi-data-source tests#2479
Merged
cwperks merged 1 commit intoJul 20, 2026
Merged
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit 2e84678)Here are some key observations to aid the review process:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
=======================================
Coverage 70.45% 70.45%
=======================================
Files 104 104
Lines 3198 3198
Branches 574 574
=======================================
Hits 2253 2253
Misses 773 773
Partials 172 172 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cwperks
force-pushed
the
agent/disable-multitenancy-in-mds-tests
branch
from
July 20, 2026 13:05
b6c1d8e to
441429e
Compare
Contributor
|
Persistent review updated to latest commit 441429e |
Signed-off-by: Craig Perkins <craig5008@gmail.com>
cwperks
force-pushed
the
agent/disable-multitenancy-in-mds-tests
branch
from
July 20, 2026 13:17
441429e to
2e84678
Compare
Contributor
|
Persistent review updated to latest commit 2e84678 |
cwperks
marked this pull request as ready for review
July 20, 2026 15:18
cwperks
requested review from
DarshitChanpura,
RyanL1997 and
derek-ho
as code owners
July 20, 2026 15:18
RyanL1997
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The multi-data-source workflow enabled both MDS and Security multi-tenancy. Data source saved objects were therefore created in the caller's tenant, while the credential lookup used the internal Dashboards user and could not find the tenant-specific object. The resulting
Saved object [data-source/<id>] not founderrors caused the Security MDS tests to fail consistently.MDS and Security multi-tenancy are intended to be mutually exclusive. This change runs the MDS coverage in the supported non-multitenant configuration instead of changing Dashboards credential lookup behavior to support the invalid combination.
Validation
git diff --checkpassed