Skip to content

Disable multi-tenancy in multi-data-source tests#2479

Merged
cwperks merged 1 commit into
opensearch-project:mainfrom
cwperks:agent/disable-multitenancy-in-mds-tests
Jul 20, 2026
Merged

Disable multi-tenancy in multi-data-source tests#2479
cwperks merged 1 commit into
opensearch-project:mainfrom
cwperks:agent/disable-multitenancy-in-mds-tests

Conversation

@cwperks

@cwperks cwperks commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • disable Security multi-tenancy in the multi-data-source Cypress workflow
  • apply the same backend Security configuration to both local and remote OpenSearch fixtures
  • remove the tenancy-only assertion from the MDS Cypress specification
  • align the multi-data-source server integration suite with the non-multitenant configuration

Root cause

The multi-data-source workflow enabled both MDS and Security multi-tenancy. Data source saved objects were therefore created in the caller's tenant, while the credential lookup used the internal Dashboards user and could not find the tenant-specific object. The resulting Saved object [data-source/<id>] not found errors caused the Security MDS tests to fail consistently.

MDS and Security multi-tenancy are intended to be mutually exclusive. This change runs the MDS coverage in the supported non-multitenant configuration instead of changing Dashboards credential lookup behavior to support the invalid combination.

Validation

  • multi-data-source server integration block: 6 tests passed against two local OpenSearch clusters with unmodified Dashboards core
  • ESLint passed for the modified JavaScript and TypeScript tests
  • Prettier passed for the modified JavaScript and TypeScript tests
  • workflow YAML parsed successfully
  • git diff --check passed

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 2e84678)

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.45%. Comparing base (0fda68d) to head (2e84678).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2479   +/-   ##
=======================================
  Coverage   70.45%   70.45%           
=======================================
  Files         104      104           
  Lines        3198     3198           
  Branches      574      574           
=======================================
  Hits         2253     2253           
  Misses        773      773           
  Partials      172      172           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks
cwperks force-pushed the agent/disable-multitenancy-in-mds-tests branch from b6c1d8e to 441429e Compare July 20, 2026 13:05
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 441429e

Signed-off-by: Craig Perkins <craig5008@gmail.com>
@cwperks
cwperks force-pushed the agent/disable-multitenancy-in-mds-tests branch from 441429e to 2e84678 Compare July 20, 2026 13:17
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 2e84678

@cwperks
cwperks marked this pull request as ready for review July 20, 2026 15:18
@cwperks
cwperks merged commit e23f23c into opensearch-project:main Jul 20, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants