Commit 19e6693
Hanyu Wei
feat(ppl): support bare-field join criteria
Let `on`/`where` join criteria accept a bare field name (or `AND` of bare
fields) as shorthand for the qualified equality on that common field:
source=t1 | inner join on a t2 == on t1.a = t2.a
source=t1 | inner join on a AND b t2 == on t1.a = t2.a AND t1.b = t2.b
source=t1 | join on a t2 == on t1.a = t2.a (no prefix/alias)
The shorthand behaves exactly like the explicit `on l.f = r.f` criteria: it
KEEPS BOTH key columns (the right key renamed `<rightAlias>.f`, or
`<rightTable>.f` when no alias is given). This differs from the field-list
join (`join f t2`), which merges the duplicate key to a single column.
Implementation:
- Grammar: reorder the joinCommand alternatives so the criteria alternative
is listed first. This lets the no-prefix form `join on a <right>` parse `on`
as the criteria keyword instead of the field-list alternative greedily
consuming `on`/`where` as a field name. ANTLR ALL(*) picks the first-listed
alternative on genuine ambiguity.
- AstBuilder: a bare single-part field (or AND-chain of them) is left as the
join condition verbatim -- the unresolved AST reflects what the user wrote.
- Planner (CalciteRelNodeVisitor.visitJoin): the criteria branch detects a
bare-field condition and builds the equi-join from it, resolving each field
by stack position (LEFT.f = RIGHT.f) via the existing
buildJoinConditionByFieldName helper. No new planner code, and no AST
mutation. Because resolution is positional rather than by qualifier, a
self-join `join on f t` is a genuine cross-scan equi-join rather than the
`f = f` tautology a name-based rewrite would collapse to.
Adds AstBuilder, Calcite plan, anonymizer, and integration tests; updates the
join command user manual.
Signed-off-by: Hanyu Wei <weihanyu@amazon.com>join on <field> shorthand1 parent 2c4215f commit 19e6693
9 files changed
Lines changed: 498 additions & 8 deletions
File tree
- core/src/main/java/org/opensearch/sql/calcite
- utils
- docs/user/ppl/cmd
- integ-test/src/test/java/org/opensearch/sql/calcite/remote
- ppl/src
- main
- antlr
- java/org/opensearch/sql/ppl/parser
- test/java/org/opensearch/sql/ppl
- calcite
- parser
- utils
Lines changed: 16 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1889 | 1889 | | |
1890 | 1890 | | |
1891 | 1891 | | |
1892 | | - | |
1893 | | - | |
1894 | | - | |
1895 | | - | |
| 1892 | + | |
| 1893 | + | |
| 1894 | + | |
| 1895 | + | |
| 1896 | + | |
| 1897 | + | |
| 1898 | + | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
1896 | 1908 | | |
1897 | 1909 | | |
1898 | 1910 | | |
| |||
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
| |||
37 | 41 | | |
38 | 42 | | |
39 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
40 | 62 | | |
41 | 63 | | |
42 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
| |||
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
43 | | - | |
| 46 | + | |
44 | 47 | | |
45 | 48 | | |
46 | 49 | | |
| |||
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
74 | | - | |
| 77 | + | |
75 | 78 | | |
76 | 79 | | |
77 | 80 | | |
| |||
Lines changed: 100 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
928 | 928 | | |
929 | 929 | | |
930 | 930 | | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
931 | 1031 | | |
932 | 1032 | | |
933 | 1033 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
729 | 729 | | |
730 | 730 | | |
731 | 731 | | |
732 | | - | |
733 | | - | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
734 | 735 | | |
735 | 736 | | |
736 | 737 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
| 329 | + | |
| 330 | + | |
329 | 331 | | |
330 | 332 | | |
331 | 333 | | |
| |||
0 commit comments