Skip to content

Commit 2b18d45

Browse files
ahkcsahkcs
committed
Strip empty _source excludes from explain fixtures and docs
OpenSearch 3.7's FetchSourceContext no longer emits "excludes":[] when the list is empty. Sweep remaining fixtures (expectedOutput/**, legacy explain fixtures, yamlRestTest) and user docs to drop the stale field so textual comparisons match the new server output. YAML fixtures using `|` literal block style (most calcite/*) apply cleanly; a few legacy ppl/*.yaml fixtures that use folded double-quoted strings may need fold-offset regeneration once those ITs surface. Signed-off-by: Kai Huang <ahkcs@amazon.com>
1 parent 771b658 commit 2b18d45

296 files changed

Lines changed: 346 additions & 407 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/dev/opensearch-nested-field-subquery.md‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ GET /employee_nested/_search
5353
"_source": {
5454
"includes": [
5555
"name"
56-
],
57-
"excludes": []
56+
]
5857
}
5958
}
6059
@@ -110,8 +109,7 @@ WHERE EXISTS(SELECT *
110109
"_source": {
111110
"includes": [
112111
"name"
113-
],
114-
"excludes": []
112+
]
115113
}
116114
}
117115

‎docs/dev/sql-nested-function-select-clause.md‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ A basic nested function in the SELECT clause and output DSL pushed to OpenSearch
106106
"_source": {
107107
"includes": [
108108
"message.info"
109-
],
110-
"excludes": []
109+
]
111110
}
112111
}
113112
}
@@ -147,8 +146,7 @@ Example with multiple SELECT clause function calls sharing same path. These two
147146
"includes": [
148147
"message.info",
149148
"message.author"
150-
],
151-
"excludes": []
149+
]
152150
}
153151
}
154152
}
@@ -187,8 +185,7 @@ An example with multiple nested function calls in the SELECT clause having diffe
187185
"_source": {
188186
"includes": [
189187
"comment.data"
190-
],
191-
"excludes": []
188+
]
192189
}
193190
}
194191
}
@@ -207,8 +204,7 @@ An example with multiple nested function calls in the SELECT clause having diffe
207204
"_source": {
208205
"includes": [
209206
"message.info"
210-
],
211-
"excludes": []
207+
]
212208
}
213209
}
214210
}

‎docs/user/beyond/fulltext.rst‎

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ Explain::
8080
"includes" : [
8181
"account_number",
8282
"address"
83-
],
84-
"excludes" : [ ]
83+
]
8584
}
8685
}
8786

@@ -150,8 +149,7 @@ Explain::
150149
"includes" : [
151150
"account_number",
152151
"address"
153-
],
154-
"excludes" : [ ]
152+
]
155153
}
156154
}
157155

@@ -230,8 +228,7 @@ Explain::
230228
"includes" : [
231229
"firstname",
232230
"lastname"
233-
],
234-
"excludes" : [ ]
231+
]
235232
}
236233
}
237234

@@ -311,8 +308,7 @@ Explain::
311308
"includes" : [
312309
"account_number",
313310
"address"
314-
],
315-
"excludes" : [ ]
311+
]
316312
}
317313
}
318314

@@ -386,8 +382,7 @@ Explain::
386382
"includes" : [
387383
"account_number",
388384
"address"
389-
],
390-
"excludes" : [ ]
385+
]
391386
}
392387
}
393388

@@ -492,8 +487,7 @@ Explain::
492487
"account_number",
493488
"address",
494489
"_score"
495-
],
496-
"excludes" : [ ]
490+
]
497491
},
498492
"sort" : [
499493
{

‎docs/user/beyond/partiql.rst‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,7 @@ Explain::
286286
"_source" : {
287287
"includes" : [
288288
"projects.name"
289-
],
290-
"excludes" : [ ]
289+
]
291290
}
292291
}
293292
}
@@ -305,8 +304,7 @@ Explain::
305304
"_source" : {
306305
"includes" : [
307306
"name"
308-
],
309-
"excludes" : [ ]
307+
]
310308
}
311309
}
312310

@@ -423,8 +421,7 @@ Explain::
423421
"_source" : {
424422
"includes" : [
425423
"name"
426-
],
427-
"excludes" : [ ]
424+
]
428425
}
429426
}
430427

‎docs/user/dql/basics.rst‎

Lines changed: 15 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ Explain::
136136
"includes" : [
137137
"firstname",
138138
"lastname"
139-
],
140-
"excludes" : [ ]
139+
]
141140
}
142141
}
143142

@@ -181,8 +180,7 @@ Explain::
181180
"_routing",
182181
"_sort",
183182
"lastname"
184-
],
185-
"excludes" : [ ]
183+
]
186184
}
187185
}
188186

@@ -220,8 +218,7 @@ Explain::
220218
"_source" : {
221219
"includes" : [
222220
"account_number"
223-
],
224-
"excludes" : [ ]
221+
]
225222
}
226223
}
227224

@@ -260,8 +257,7 @@ Explain::
260257
"_source" : {
261258
"includes" : [
262259
"age"
263-
],
264-
"excludes" : [ ]
260+
]
265261
},
266262
"stored_fields" : "age",
267263
"aggregations" : {
@@ -422,8 +418,7 @@ Explain::
422418
"_source" : {
423419
"includes" : [
424420
"account_number"
425-
],
426-
"excludes" : [ ]
421+
]
427422
}
428423
}
429424

@@ -493,8 +488,7 @@ Explain::
493488
"includes" : [
494489
"account_number",
495490
"employer"
496-
],
497-
"excludes" : [ ]
491+
]
498492
}
499493
}
500494

@@ -539,8 +533,7 @@ Explain::
539533
"_source" : {
540534
"includes" : [
541535
"age"
542-
],
543-
"excludes" : [ ]
536+
]
544537
},
545538
"stored_fields" : "age",
546539
"aggregations" : {
@@ -603,8 +596,7 @@ Explain::
603596
"_source" : {
604597
"includes" : [
605598
"account_number"
606-
],
607-
"excludes" : [ ]
599+
]
608600
},
609601
"stored_fields" : "account_number",
610602
"aggregations" : {
@@ -667,8 +659,7 @@ Explain::
667659
"_source" : {
668660
"includes" : [
669661
"age"
670-
],
671-
"excludes" : [ ]
662+
]
672663
},
673664
"stored_fields" : "age",
674665
"aggregations" : {
@@ -731,8 +722,7 @@ Explain::
731722
"_source" : {
732723
"includes" : [
733724
"script"
734-
],
735-
"excludes" : [ ]
725+
]
736726
},
737727
"stored_fields" : "abs(age)",
738728
"script_fields" : {
@@ -815,8 +805,7 @@ Explain::
815805
"includes" : [
816806
"age",
817807
"MAX"
818-
],
819-
"excludes" : [ ]
808+
]
820809
},
821810
"stored_fields" : "age",
822811
"aggregations" : {
@@ -904,8 +893,7 @@ Explain::
904893
"_source" : {
905894
"includes" : [
906895
"account_number"
907-
],
908-
"excludes" : [ ]
896+
]
909897
},
910898
"sort" : [
911899
{
@@ -955,8 +943,7 @@ Explain::
955943
"_source" : {
956944
"includes" : [
957945
"employer"
958-
],
959-
"excludes" : [ ]
946+
]
960947
},
961948
"sort" : [
962949
{
@@ -1075,8 +1062,7 @@ Explain::
10751062
"_source" : {
10761063
"includes" : [
10771064
"account_number"
1078-
],
1079-
"excludes" : [ ]
1065+
]
10801066
},
10811067
"sort" : [
10821068
{
@@ -1120,8 +1106,7 @@ Explain::
11201106
"_source" : {
11211107
"includes" : [
11221108
"account_number"
1123-
],
1124-
"excludes" : [ ]
1109+
]
11251110
},
11261111
"sort" : [
11271112
{

‎docs/user/dql/complex.rst‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ Explain::
112112
"size" : 200,
113113
"from" : 0,
114114
"_source" : {
115-
"excludes" : [ ],
116115
"includes" : [
117116
"firstname",
118117
"lastname",
@@ -223,8 +222,7 @@ Explain::
223222
"firstname",
224223
"lastname",
225224
"age"
226-
],
227-
"excludes" : [ ]
225+
]
228226
}
229227
}
230228

@@ -325,7 +323,6 @@ Explain::
325323
"size" : 200,
326324
"from" : 0,
327325
"_source" : {
328-
"excludes" : [ ],
329326
"includes" : [
330327
"id",
331328
"name"
@@ -338,7 +335,6 @@ Explain::
338335
"size" : 200,
339336
"from" : 0,
340337
"_source" : {
341-
"excludes" : [ ],
342338
"includes" : [
343339
"account_number",
344340
"firstname",

‎docs/user/interfaces/endpoint.rst‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ Explain::
8888
"includes" : [
8989
"firstname",
9090
"lastname"
91-
],
92-
"excludes" : [ ]
91+
]
9392
}
9493
}
9594

‎docs/user/interfaces/protocol.rst‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ Explain::
8080
"firstname",
8181
"lastname",
8282
"balance"
83-
],
84-
"excludes" : [ ]
83+
]
8584
}
8685
}
8786

‎integ-test/src/test/resources/expectedOutput/aggregation_query_explain.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
"address",
77
"script",
88
"COUNT"
9-
],
10-
"excludes" : [ ]
9+
]
1110
},
1211
"stored_fields" : [
1312
"address",

‎integ-test/src/test/resources/expectedOutput/between_query.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
"_source" : {
55
"includes" : [
66
"account_number"
7-
],
8-
"excludes" : [ ]
7+
]
98
},
109
"script_fields" : {
1110
"test" : {

0 commit comments

Comments
 (0)