[2.19-dev] Disable Calcite by default (#4920)

* [2.19-dev] Disable Calcite by default

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Add config in yaml tests

Signed-off-by: Lantao Jin <ltjin@amazon.com>

---------

Signed-off-by: Lantao Jin <ltjin@amazon.com>

Author: LantaoJin

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4513.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
   - do:
       bulk:
         index: test
@@ -10,6 +15,15 @@ setup:
           - '{"value": "2"}'
           - '{"index": {"_id": "3"}}'
           - '{"value": "3"}'
+
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "handle agg script push down on metadata field":
   - skip:

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4550.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
   - do:
       indices.create:
         index: test_data_2023
@@ -25,6 +30,14 @@ setup:
           - '{"index":{}}'
           - '{"@timestamp":"2023-10-08T10:00:02.000Z","packets":30}'
 
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "timechart with millisecond span":
   - skip:

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4581.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
   - do:
       indices.create:
         index: opensearch-sql_test_index_otel_logs
@@ -33,6 +38,14 @@ setup:
           - '{"index":{}}'
           - '{"@timestamp":"2023-10-08T10:00:07.000Z","severityNumber":9,"flags":1}'
 
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "timechart with grouping by non-string field":
   - skip:

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4582.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
   - do:
       indices.create:
         index: opensearch-sql_test_index_otel_logs
@@ -33,6 +38,14 @@ setup:
           - '{"index":{}}'
           - '{"@timestamp":"2024-01-15T10:00:07.000Z","severityNumber":18,"severityText":"TRACE10"}'
 
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "timechart with limit should use max aggregation for OTHER category":
   - skip:

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4632.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled: true
   - do:
       indices.create:
         index: events
@@ -33,6 +38,14 @@ setup:
           - '{"index":{}}'
           - '{"@timestamp":"2023-01-01T10:35:00Z","host":"server2","packets":90}'
 
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "timechart count() by field should not return empty buckets":
   - skip:

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4644.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
   - do:
       indices.create:
         index: timechart-eval-bug
@@ -23,6 +28,14 @@ setup:
           - '{"index":{}}'
           - '{"@timestamp":"2024-05-03T00:20:00Z","user":"bob"}'
 
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "timechart with eval on @timestamp field":
   - skip:

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4740.yml

@@ -1,4 +1,9 @@
 setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
   - do:
       indices.create:
         index: test_binning_4740
@@ -29,6 +34,14 @@ setup:
           - '{"index":{}}'
           - '{"@timestamp":"2024-01-01T00:20:00.000Z","age":"45","balance":"5000.0","name":"Eve"}'
 
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+
 ---
 "bin with numeric field using WIDTH_BUCKET - issue 4740":
   - skip:

opensearch/src/main/java/org/opensearch/sql/opensearch/setting/OpenSearchSettings.java

@@ -170,7 +170,7 @@ public class OpenSearchSettings extends Settings {
   public static final Setting<?> CALCITE_ENGINE_ENABLED_SETTING =
       Setting.boolSetting(
           Key.CALCITE_ENGINE_ENABLED.getKeyValue(),
-          true,
+          false,
           Setting.Property.NodeScope,
           Setting.Property.Dynamic);