Skip to content

Commit bcbc23f

Browse files
Merge branch 'opensearch-project:main' into main
2 parents 0d74491 + a8069d1 commit bcbc23f

16 files changed

Lines changed: 138 additions & 23 deletions

File tree

.github/workflows/sql-test-and-build-workflow.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ jobs:
5252
run: |
5353
chown -R 1000:1000 `pwd`
5454
if [ "${{ matrix.test-type }}" = "unit" ]; then
55-
su `id -un 1000` -c "./gradlew --continue build -x integTest -x doctest"
55+
su `id -un 1000` -c "./gradlew --continue build -x integTest -x yamlRestTest -x doctest"
5656
elif [ "${{ matrix.test-type }}" = "integration" ]; then
57-
su `id -un 1000` -c "./gradlew --continue integTest"
57+
su `id -un 1000` -c "./gradlew --continue integTest yamlRestTest"
5858
else
5959
su `id -un 1000` -c "./gradlew --continue doctest"
6060
fi
@@ -130,9 +130,9 @@ jobs:
130130
- name: Build and Test
131131
run: |
132132
if [ "${{ matrix.test-type }}" = "unit" ]; then
133-
./gradlew --continue build -x integTest -x doctest ${{ matrix.entry.os_build_args }}
133+
./gradlew --continue build -x integTest -x yamlRestTest -x doctest ${{ matrix.entry.os_build_args }}
134134
elif [ "${{ matrix.test-type }}" = "integration" ]; then
135-
./gradlew --continue integTest ${{ matrix.entry.os_build_args }}
135+
./gradlew --continue integTest yamlRestTest ${{ matrix.entry.os_build_args }}
136136
else
137137
./gradlew --continue doctest ${{ matrix.entry.os_build_args }}
138138
fi

core/src/main/java/org/opensearch/sql/ast/dsl/AstDSL.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public UnresolvedPlan describe(String tableName) {
114114
}
115115

116116
public static UnresolvedPlan search(UnresolvedPlan input, String queryString) {
117-
return new Search(input, queryString);
117+
return new Search(input, queryString, null);
118118
}
119119

120120
public UnresolvedPlan subqueryAlias(UnresolvedPlan child, String alias) {

core/src/main/java/org/opensearch/sql/ast/expression/SearchAnd.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ public String toQueryString() {
2727
return left.toQueryString() + " AND " + right.toQueryString();
2828
}
2929

30+
@Override
31+
public String toAnonymizedString() {
32+
return left.toAnonymizedString() + " AND " + right.toAnonymizedString();
33+
}
34+
3035
@Override
3136
public List<? extends UnresolvedExpression> getChild() {
3237
return Arrays.asList(left, right);

core/src/main/java/org/opensearch/sql/ast/expression/SearchComparison.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
package org.opensearch.sql.ast.expression;
77

8+
import static org.opensearch.sql.utils.QueryStringUtils.maskField;
9+
810
import java.util.Arrays;
911
import java.util.List;
1012
import lombok.EqualsAndHashCode;
@@ -63,6 +65,12 @@ public String toQueryString() {
6365
}
6466
}
6567

68+
@Override
69+
public String toAnonymizedString() {
70+
String fieldName = QueryStringUtils.escapeFieldName(field.getField().toString());
71+
return maskField(fieldName) + " " + operator.symbol + " ***";
72+
}
73+
6674
@Override
6775
public List<? extends UnresolvedExpression> getChild() {
6876
return Arrays.asList(field, value);

core/src/main/java/org/opensearch/sql/ast/expression/SearchExpression.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ public abstract class SearchExpression extends UnresolvedExpression {
1717
*/
1818
public abstract String toQueryString();
1919

20+
/**
21+
* Convert the search expression to anonymized string
22+
*
23+
* @return the anonymized string
24+
*/
25+
public abstract String toAnonymizedString();
26+
2027
@Override
2128
public <R, C> R accept(AbstractNodeVisitor<R, C> nodeVisitor, C context) {
2229
return nodeVisitor.visitChildren(this, context);

core/src/main/java/org/opensearch/sql/ast/expression/SearchGroup.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ public String toQueryString() {
2626
return "(" + expression.toQueryString() + ")";
2727
}
2828

29+
@Override
30+
public String toAnonymizedString() {
31+
if (expression instanceof SearchGroup) {
32+
return expression.toAnonymizedString();
33+
}
34+
return "(" + expression.toAnonymizedString() + ")";
35+
}
36+
2937
@Override
3038
public List<? extends UnresolvedExpression> getChild() {
3139
return Collections.singletonList(expression);

core/src/main/java/org/opensearch/sql/ast/expression/SearchIn.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ public String toQueryString() {
3333
return fieldName + ":( " + valueList + " )";
3434
}
3535

36+
@Override
37+
public String toAnonymizedString() {
38+
return "identifier IN ***";
39+
}
40+
3641
@Override
3742
public List<? extends UnresolvedExpression> getChild() {
3843
List<UnresolvedExpression> children = new ArrayList<>();

core/src/main/java/org/opensearch/sql/ast/expression/SearchLiteral.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,11 @@ public String toQueryString() {
5555
return QueryStringUtils.escapeLuceneSpecialCharacters(text);
5656
}
5757

58+
@Override
59+
public String toAnonymizedString() {
60+
return "***";
61+
}
62+
5863
@Override
5964
public List<? extends UnresolvedExpression> getChild() {
6065
return Collections.singletonList(literal);

core/src/main/java/org/opensearch/sql/ast/expression/SearchNot.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ public String toQueryString() {
2626
return "NOT(" + expression.toQueryString() + ")";
2727
}
2828

29+
@Override
30+
public String toAnonymizedString() {
31+
return "NOT(" + expression.toAnonymizedString() + ")";
32+
}
33+
2934
@Override
3035
public List<? extends UnresolvedExpression> getChild() {
3136
return Collections.singletonList(expression);

core/src/main/java/org/opensearch/sql/ast/expression/SearchOr.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ public String toQueryString() {
2727
return left.toQueryString() + " OR " + right.toQueryString();
2828
}
2929

30+
@Override
31+
public String toAnonymizedString() {
32+
return left.toAnonymizedString() + " OR " + right.toAnonymizedString();
33+
}
34+
3035
@Override
3136
public List<? extends UnresolvedExpression> getChild() {
3237
return Arrays.asList(left, right);

0 commit comments

Comments
 (0)