Commit c4583ab
committed
Stabilize more PPL ITs on the analytics-engine route (sort/streamstats/IP-UDT/metadata/strip-verifier)
Brings 16 more PPL IT classes to parity on the analytics-engine route
(-Dtests.analytics.parquet_indices=true). Route-only divergences are
gated AE-only via @RequiresCapability + a matching build.gradle
excludeTestsMatching; the v2/Calcite path runs every test unchanged.
Strip-verifier (the #5541 guardrail):
- AnalyticsUnsupportedFieldStripVerifyIT was failing because 8 datasets
carry a multi-value JSON array for a scalar-mapped field, which the
parquet store rejects at bulk load. That's a cardinality limitation,
not an unsupported field *type*, so it's out of scope for the type
strip — the same situation as the existing `join` out-of-scope skip.
Added a curated MULTI_VALUE_DATASETS allowlist + safeToSkipForMultiValueLoad
that skips only the exact multi-value signature on a known dataset;
any other failure still surfaces loudly, and Legs 2-3 still type-check
every index that loads.
Init-load contamination (not divergences — fixed, not gated):
- CalciteWhereCommandIT failed on testDoubleEqual* because init() loaded
game_of_thrones (base) and deep_nested (subclass), both multi-value
datasets whose bulk-load failure aborted init() and mislabeled the
first test. Guarded both loads with isAnalyticsParquetIndicesEnabled();
no test in the hierarchy queries them on the AE route. 32/32 now pass.
Engine divergences gated (new capabilities):
- SORT_TIE_ORDER_UNSTABLE: sort on a non-unique key leaves ties in an
engine-dependent order (3 CalcitePPLSortIT tests)
- INVALID_DATETIME_ERROR_SHAPE: dayname/monthname over an invalid literal
throw a different message shape (2 tests)
- RAND_SEED_UNSUPPORTED: seeded RAND(seed) is rejected on AE
- IP_UDT_BINARY_REPRESENTATION: the IP UDT is materialized as BINARY, so
cast(... as IP) and cidrmatch over an IP column fail (2 tests)
- TIME_TYPE_WIDENED_TO_TIMESTAMP: a TIME field reads back as TIMESTAMP,
defeating TIMEDIFF's [TIME,TIME] signature
- BINARY_FIELD_STRIPPED: binary fields are stripped at load
- VALUES_LIMIT_NOT_HONORED: values()/list() ignore the configured limit
- INDEX_METADATA: _index metadata not exposed (sibling of ID_METADATA)
- CROSS_INDEX_OBJECT_LEAF_MERGE: an object leaf in only some wildcard
member indices resolves to FIELD_NOT_FOUND
- TEXT_KEYWORD_PUSHDOWN_REWRITE: like() doesn't rewrite to .keyword in
the explain plan (no Lucene term-pushdown)
- LUCENE_PUSHDOWN_EXPLAIN: a test asserting a Lucene SORT-> pushdown
fragment can't match the DataFusion plan
Reused existing capabilities:
- WILDCARD_COLUMN_ORDER: streamstats carries all source columns through;
AE returns them in a different order (4 CalciteReverseCommandIT tests)
- HEAD_WITHOUT_STABLE_SORT: head N without a stable sort (testHeadThenSort,
testAppendWithMergedColumn)
- DEDUP_NONDETERMINISTIC: consecutive dedup has no working V2 fallback on
the AE route
Out of scope:
- FieldsCommandIT.testEnhancedFieldsWhenCalciteDisabled asserts the
Calcite-DISABLED error; the AE route is always Calcite-enabled.
build.gradle exclude only.
Results (this batch, on the AE route): 16 classes, 373 run, 0 failures
(was 24 failures). V2 baseline: 408 run, 0 failures, 2 pre-existing/
by-design skips (none from these gates).
Signed-off-by: Kai Huang <ahkcs@amazon.com>1 parent 08d8ba1 commit c4583ab
18 files changed
Lines changed: 364 additions & 3 deletions
File tree
- integ-test
- src/test/java/org/opensearch/sql
- calcite/remote
- ppl
- util
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1285 | 1285 | | |
1286 | 1286 | | |
1287 | 1287 | | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
1288 | 1336 | | |
1289 | 1337 | | |
1290 | 1338 | | |
| |||
Lines changed: 49 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
73 | 99 | | |
74 | 100 | | |
75 | 101 | | |
| |||
109 | 135 | | |
110 | 136 | | |
111 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
112 | 144 | | |
113 | 145 | | |
114 | 146 | | |
| |||
380 | 412 | | |
381 | 413 | | |
382 | 414 | | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
383 | 432 | | |
384 | 433 | | |
385 | 434 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
| 12 | + | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
| |||
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
18 | 26 | | |
19 | 27 | | |
20 | 28 | | |
| |||
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
169 | 172 | | |
170 | 173 | | |
171 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
172 | 178 | | |
173 | 179 | | |
174 | 180 | | |
| |||
420 | 426 | | |
421 | 427 | | |
422 | 428 | | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
423 | 434 | | |
424 | 435 | | |
425 | 436 | | |
| |||
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| 27 | + | |
25 | 28 | | |
26 | 29 | | |
27 | 30 | | |
| |||
195 | 198 | | |
196 | 199 | | |
197 | 200 | | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
198 | 206 | | |
199 | 207 | | |
200 | 208 | | |
| |||
258 | 266 | | |
259 | 267 | | |
260 | 268 | | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
261 | 274 | | |
262 | 275 | | |
263 | 276 | | |
| |||
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
216 | 218 | | |
217 | 219 | | |
218 | 220 | | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
219 | 226 | | |
220 | 227 | | |
221 | 228 | | |
| |||
760 | 767 | | |
761 | 768 | | |
762 | 769 | | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
763 | 775 | | |
764 | 776 | | |
765 | 777 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
887 | 889 | | |
888 | 890 | | |
889 | 891 | | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
890 | 897 | | |
891 | 898 | | |
892 | 899 | | |
| |||
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
165 | 167 | | |
166 | 168 | | |
167 | 169 | | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
168 | 175 | | |
169 | 176 | | |
170 | 177 | | |
| |||
200 | 207 | | |
201 | 208 | | |
202 | 209 | | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
203 | 215 | | |
204 | 216 | | |
205 | 217 | | |
| |||
315 | 327 | | |
316 | 328 | | |
317 | 329 | | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
318 | 335 | | |
319 | 336 | | |
320 | 337 | | |
| |||
0 commit comments