Commit c6360e9
authored
Branch percentile and sum-null IT expectations for the analytics-engine route (#5522)
CalcitePPLAggregationIT.testPercentile, testSumNull, and testSumGroupByNullValue
hard-coded expectations from the Calcite DSL-pushdown path, so they failed when
run through the analytics-engine (DataFusion) backend via
-Dtests.analytics.parquet_indices=true:
- percentile() is approximate. DataFusion's t-digest interpolation returns 46576
for percentile(balance, 90) where the OpenSearch/Calcite percentile_approx
returns 48086 (p50 agrees). Both are valid approximations.
- SUM over an all-null bucket is null per the SQL spec. The DSL-pushdown path
returns 0 (a known quirk, #3408); DataFusion follows the spec like
Calcite-no-pushdown and returns null.
Branch the expected values on the existing isAnalyticsParquetIndicesEnabled()
helper, matching the pattern already used in StatsCommandIT.testSumWithNull. No
production code change; both engine paths now pass.
Signed-off-by: Kai Huang <ahkcs@amazon.com>1 parent e5de8f6 commit c6360e9
1 file changed
Lines changed: 14 additions & 4 deletions
Lines changed: 14 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
980 | 980 | | |
981 | 981 | | |
982 | 982 | | |
983 | | - | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
984 | 988 | | |
985 | 989 | | |
986 | 990 | | |
| |||
990 | 994 | | |
991 | 995 | | |
992 | 996 | | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
993 | 1001 | | |
994 | 1002 | | |
995 | | - | |
| 1003 | + | |
996 | 1004 | | |
997 | 1005 | | |
998 | 1006 | | |
999 | 1007 | | |
1000 | | - | |
| 1008 | + | |
1001 | 1009 | | |
1002 | 1010 | | |
1003 | 1011 | | |
| |||
1061 | 1069 | | |
1062 | 1070 | | |
1063 | 1071 | | |
1064 | | - | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
1065 | 1075 | | |
1066 | 1076 | | |
1067 | 1077 | | |
| |||
0 commit comments