Skip to content

Commit c6a8388

Browse files
committed
Revert CalciteToolsHelper comment to sync with main
Signed-off-by: Kai Huang <ahkcs@amazon.com>
1 parent b13d88b commit c6a8388

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

core/src/main/java/org/opensearch/sql/calcite/utils/CalciteToolsHelper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,8 +422,7 @@ public RelNode visit(TableScan scan) {
422422
}
423423
};
424424
rel = rel.accept(shuttle);
425-
// Context classloader is set by callers (QueryService.executeWithCalcite/explainWithCalcite)
426-
// to support patched Calcite (CALCITE-3745) Janino compilation.
425+
// the line we changed here
427426
try (Connection connection = context.connection) {
428427
final RelRunner runner = connection.unwrap(RelRunner.class);
429428
PreparedStatement preparedStatement = runner.prepareStatement(rel);

core/src/main/java/org/opensearch/sql/executor/QueryService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import lombok.RequiredArgsConstructor;
1414
import lombok.extern.log4j.Log4j2;
1515
import org.apache.calcite.jdbc.CalciteSchema;
16-
import org.opensearch.sql.calcite.utils.CalciteClassLoaderHelper;
1716
import org.apache.calcite.plan.RelTraitDef;
1817
import org.apache.calcite.rel.RelCollation;
1918
import org.apache.calcite.rel.RelCollations;
@@ -36,6 +35,7 @@
3635
import org.opensearch.sql.calcite.SysLimit;
3736
import org.opensearch.sql.calcite.plan.rel.LogicalSystemLimit;
3837
import org.opensearch.sql.calcite.plan.rel.LogicalSystemLimit.SystemLimitType;
38+
import org.opensearch.sql.calcite.utils.CalciteClassLoaderHelper;
3939
import org.opensearch.sql.common.response.ResponseListener;
4040
import org.opensearch.sql.common.setting.Settings;
4141
import org.opensearch.sql.common.utils.QueryContext;

opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/CalciteScriptEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
import org.apache.calcite.util.Util;
7070
import org.checkerframework.checker.nullness.qual.Nullable;
7171
import org.opensearch.index.fielddata.ScriptDocValues;
72-
import org.opensearch.sql.calcite.utils.CalciteClassLoaderHelper;
7372
import org.opensearch.script.AggregationScript;
7473
import org.opensearch.script.FieldScript;
7574
import org.opensearch.script.FilterScript;
@@ -78,6 +77,7 @@
7877
import org.opensearch.script.ScriptEngine;
7978
import org.opensearch.script.StringSortScript;
8079
import org.opensearch.search.lookup.SourceLookup;
80+
import org.opensearch.sql.calcite.utils.CalciteClassLoaderHelper;
8181
import org.opensearch.sql.data.model.ExprTimestampValue;
8282
import org.opensearch.sql.opensearch.storage.script.aggregation.CalciteAggregationScriptFactory;
8383
import org.opensearch.sql.opensearch.storage.script.field.CalciteFieldScriptFactory;

0 commit comments

Comments
 (0)