Commit cd45dd1
committed
Stabilize CalcitePPLCaseFunctionIT on the analytics-engine route
Two test-infra issues caused 5 of the class's 6 analytics-route failures:
- init() seeds four extra weblogs docs via unconditional raw PUTs
(appendDataForBadResponse). init() runs as @before before every test method,
and the analytics-engine parquet-backed store is append-only on same-_id PUT,
so the docs accumulated a duplicate per method and inflated row counts across
the suite. Guard the seeding on a pre-loadIndex isIndexExist check.
- The otel_logs dataset has a multi-value attributes.email.invalid_recipients
array, which the parquet/composite store rejects ('Cannot accept multiple
values for field ... of type keyword'), aborting init() for every test. Only
testNestedCaseAggWithAutoDateHistogram uses otel_logs, so skip the load on the
analytics route.
The remaining failure is a genuine route divergence, skipped via the
assumeNotAnalytics(...) registry plus a matching excludeTestsMatching entry:
- BIN_TIME_FIELD_BUCKETING: bin @timestamp then grouping by it returns the
date-histogram bucket column typed string (not timestamp) on the AE route —
testNestedCaseAggWithAutoDateHistogram.
Results (-Dtests.analytics.parquet_indices=true against the analytics route):
CalcitePPLCaseFunctionIT: 3/9 -> 8/9 pass, 1 excluded, 0 fail
v2/Calcite route unchanged: 9/9 pass.
Signed-off-by: Kai Huang <ahkcs@amazon.com>1 parent 4c1165a commit cd45dd1
2 files changed
Lines changed: 28 additions & 2 deletions
File tree
- integ-test
- src/test/java/org/opensearch/sql/calcite/remote
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1164 | 1164 | | |
1165 | 1165 | | |
1166 | 1166 | | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
1167 | 1175 | | |
1168 | 1176 | | |
1169 | 1177 | | |
| |||
Lines changed: 20 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| |||
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
34 | 40 | | |
35 | 41 | | |
36 | 42 | | |
37 | 43 | | |
38 | | - | |
39 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
40 | 55 | | |
41 | 56 | | |
42 | 57 | | |
| |||
484 | 499 | | |
485 | 500 | | |
486 | 501 | | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
487 | 505 | | |
488 | 506 | | |
489 | 507 | | |
| |||
0 commit comments