Fix SemanticCheckException not thrown (#5239)

Signed-off-by: Sunil Ramchandra Pawar <pawar_sr@apple.com>

Author: sunil9977

core/src/main/java/org/opensearch/sql/analysis/AnalysisContext.java

@@ -71,4 +71,9 @@ public TypeEnvironment pop() {
     environment = curEnv.getParent();
     return curEnv;
   }
+
+  /** Push a new isolated environment without parent access. */
+  public void pushIsolated() {
+    environment = new TypeEnvironment(null);
+  }
 }

core/src/main/java/org/opensearch/sql/analysis/Analyzer.java

@@ -423,7 +423,7 @@ public LogicalPlan visitProject(Project node, AnalysisContext context) {
 
     child = processNestedAnalysis(node.getProjectList(), namedExpressions, child, context);
 
-    context.push();
+    context.pushIsolated();
     TypeEnvironment newEnv = context.peek();
     namedExpressions.forEach(
         expr ->

core/src/test/java/org/opensearch/sql/analysis/AnalyzerTest.java

@@ -72,7 +72,6 @@
 import java.util.Optional;
 import org.apache.commons.lang3.tuple.ImmutablePair;
 import org.apache.commons.lang3.tuple.Pair;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.opensearch.sql.ast.dsl.AstDSL;
 import org.opensearch.sql.ast.expression.Argument;
@@ -898,9 +897,6 @@ public void remove_source() {
             AstDSL.field("double_value")));
   }
 
-  @Disabled(
-      "the project/remove command should shrink the type env. Should be enabled once "
-          + "https://github.com/opensearch-project/sql/issues/917 is resolved")
   @Test
   public void project_source_change_type_env() {
     SemanticCheckException exception =