Skip to content

Remove Java11 review guidance #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ykmr1224 wants to merge 1 commit into from
Closed

Remove Java11 review guidance #5079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .rules/REVIEW_GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ This document provides general code review principles and standards for the Open

### OpenSearch SQL
- **JDK 21**: Required for development
- **Java 11 Compatibility**: Maintain when possible for OpenSearch 2.x

@penghuo penghuo Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as bug fix may need to backport, I suggest we remove it when we bump to 4.x

@RyanL1997 RyanL1997 Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider adding a description of "Only security fixes or only critical bug fixes can be backported to 2.x"?

- **Module Structure**: Respect existing module boundaries (core, ppl, sql, opensearch, integ-test)
- **Test Naming**: `*IT.java` for integration tests, `*Test.java` for unit tests

Expand Down
Loading